previewer: Respond to selection events on actual window
SelectionEvent's (pushing arrow keys from the previewer window), are
emitted to all subscribers of the signal. When there's one instance
of Nautilus with a single window, this is not a problem. But when
there's multiple instances (i.e. Nautilus nightly and Nautilus, or
another subscriber to NautilusPreviewer2), the SelectionEvents
get consumed by all subscribers even though they probably don't
expect it.
This issue can be solved with the new ParentHandle property of
NautilusPreviewer2 which returns the parent window of the previewer
window. Only respond to the SelectionEvent if the ParentHandle
exists in this instance of Nautilus.
placessidebar: Always show action to stop drive when available
The "Safely Remove Drive" action is currently not shown when the
volume is mounted. This is regression from the commit gtk@60d28132.
Let's show this action again even when the volume is mounted.
sidebar: Hide format for unmounted MTP/GPhoto2 volumes
Currently, the Format action is offered also for the MTP volumes when
they are unmounted. This is a regression from the commit ab1d3019. This
is because the `uri` variable is `NULL` for unmounted volumes. This
amoung other causes critical warnings when opening popover menu for
unmounted volumes. Let's check that the activation root is native file
instead to avoid the mention issue. This will also correctly hide the
Format action also for GPhoto2 devices that are mentioned in the original
commit, but unhandled currently.
vala bindings were removed in [1] which is causing out pipelines to
fail. We don't need them anyways, so disable the build options for
libportal and libcloudproviders.
sidebar: Make cloudproviders dependency optional again
This partially reverts commit 673e6b157a125e321049d4abea3bb5a6ddc7570e.
It turns out that the cloudproviders dependency is not desired for RHEL.
9154c3f...
by
=?utf-8?q?Ant=C3=B3nio_Fernandes?= <email address hidden>
mime-actions: Don't crash on sandboxed launch
I've added g_steal_pointer() to clearly indicate that the callback
takes ownership. However, the same call where this pointer is stolen
also dereferences it for other 2 parameters (parent window and the
cancellable).
So, use a comment instead and pass the pointer directly without
clearing the local variable.
Fixes bug introduced by commit 24bb7b818a7458501afeddef26336e4b1e023dfb
