lp:~vcs-imports/pango/+git/pango

Author: Matthias Clasen
Author Date: 2024-05-14 17:12:04 UTC

Merge branch 'pangowin32-leak-fix' into 'main'

pangowin32: Fix PangoCoverage and hb_set_t leaks

See merge request GNOME/pango!740

Author: Matthias Clasen
Author Date: 2024-05-11 15:56:30 UTC

Add pango_item_get_char_offset

This provides access to the char offset of PangoItems that pango
already maintains anyway, so users don't have to recalculate it.

Author: Matthias Clasen
Author Date: 2024-05-11 15:25:59 UTC

Add a bidi test

This tests that PangoLayoutIter behaves as expected in bidi
contexts.

Related: #794

Author: Matthias Clasen
Author Date: 2024-05-07 14:45:47 UTC

Small docs addition

Add a copyable form of the bidi example text.

Author: Matthias Clasen
Author Date: 2024-03-31 07:42:29 UTC

Stop doing 'height-for-width' glyphs

Hinted hex boxes used to jump from 2 rows to 1 row below a certain
size, which causes them to get wider as they get smaller.

GSK can't handle this and it causes misrendered text, so stop
doing it.

Author: Matthias Clasen
Author Date: 2024-03-18 01:23:06 UTC

coretext: Replace Courier by Menlo

Menlo is a newer monospace font available on macOs.

Author: Matthias Clasen
Author Date: 2024-03-17 17:56:50 UTC

Try again

Author: Christian Hergert
Author Date: 2024-03-17 17:02:54 UTC

build and refcount fixes

Author: Thomas Haller
Author Date: 2024-03-12 09:10:00 UTC

pangowin32-fontmap: fix wrong usage of GWeakRef in PangoWin32Font

Casting a `PangoFontMap *fontmap` field to a `GWeakRef` is not correct.

Either use GWeakRef API throughout, or don't.

In particular, assigning a plain pointer to the field (as done in
_pango_cairo_win32_font_new()) and later treat it as GWeakRef leads to a
crash.

Don't use `GWeakRef` API. g_object_add_weak_pointer() is sufficient.
It's not thread safe, but neither was the previous code.

Fixes: 16e4dd37e5fd ('Port PangoWin32 to use GWeakRef')

Author: Matthias Clasen
Author Date: 2024-03-01 19:50:32 UTC

Fix hex box drawing

The drawing as happing outside the ink rect, which is leads
to clipping in GTK.

Author: Matthias Clasen
Author Date: 2024-02-23 14:42:47 UTC

Add pango_font_map_reload_font

This is a new api to go from a font to a modified copy and be
somewhat efficient about it. The modified font will be identical
to the original in all respects except possibly for size,
variations and cairo font options.

Test included.

Author: Matthias Clasen
Author Date: 2024-02-24 05:06:14 UTC

Improve formatting of font sizes

When serializing font descriptions, format the font size only
to the number of decimals needed to reconstruct the same Pango
units.

Code inspired by similar facilities in fonttools.

Affected tests have be updated.

Author: Matthias Clasen
Author Date: 2024-02-18 04:45:36 UTC

Add another workaround for glyph extents

Getting the extents of the glyph path helps with ensuring that
we always include all the ink.

Author: Matthias Clasen
Author Date: 2024-01-31 11:37:00 UTC

viewer: Make hint-metrics values match cairo

Make the order of the enum values match the order in cairo,
otherwise casting goes badly. This bug must have been around
for decades :(

Author: Luca Bacci
Author Date: 2024-01-09 09:54:18 UTC

Simplify code now that we always have dwrite_3.h

Author: Luca Bacci
Author Date: 2024-01-08 10:04:48 UTC

break: Improve handling of line breaking rule LB25

Also handle case ISxNU

See https://www.unicode.org/reports/tr14/#LB25
Fixes https://gitlab.gnome.org/GNOME/pango/-/issues/776

Author: Luca Bacci
Author Date: 2024-01-08 09:06:37 UTC

break: Improve handling of line breaking rule LB25

Also handle case ISxNU

See https://www.unicode.org/reports/tr14/#LB25
Fixes https://gitlab.gnome.org/GNOME/pango/-/issues/776

Author: Chun-wei Fan
Author Date: 2023-11-08 04:28:00 UTC

Add implementation of custom fonts on Windows 7/8.x

This adds an implementation of loading fonts from some specified path for
Windows 7/8.x, to complete the feature that was already added for
Windows 10 or later.

To make things cleaner, this uses some more C++-specific items that
wraps the COM interfaces that we need to implement in this case,
especially that DirectWrite stuff already needs to be done in C++ when we
are using the Windows SDK.

Author: Matthias Clasen
Author Date: 2023-10-31 00:37:45 UTC

Avoid a race

Sent the async queue already reffed, instead of hoping that the
new thread gets around to do the ref() in time.

Related: #768

Author: Luca Bacci
Author Date: 2023-09-26 12:34:31 UTC

Merge branch 'simplify-win32-hb-face' into 'main'

PangoWin32: Use HarfBuzz platform APIs if possible

See merge request GNOME/pango!701

Author: Matthias Clasen
Author Date: 2023-09-24 21:20:08 UTC

Just use a single fontconfig thread

In ac4d8f2964299d14046cb, we switched from using
GTask to using explicit threading for our fontconfig
calls, since GTask assumes a mainloop and leaks memory
otherwise. But now we are creating a new thread for
every single fontconfig call, which is a bit excessive.
As a compromise, create a single fontconfig thread
per fontmap, and use an async queue to send fontconfig
calls to that thread.

Author: Chun-wei Fan
Author Date: 2023-08-07 09:00:40 UTC

WIP: Get font features

Get the variants supported by the font. May not be correct.

Author: Chun-wei Fan
Author Date: 2023-07-31 08:14:34 UTC

fonts.c: Round size / PANGO_SCALE to nearest int

The compiler/CRT may just well stuff the results of the division as a floating-
point number into the string for the font size that forms a part of the string
that we get from pango_font_description_to_string(), which is most probably not
what we want.

So, use round() on the results of that division if not using absolute font
sizes, so that we get the font size in a nicer looking manner when we call
pango_font_description_to_string().

Author: Matthias Clasen
Author Date: 2023-07-22 21:08:11 UTC

layout: Add a missing switch case

We were not handling PANGO_OVERLINE_NONE
in a switch, triggering an assertion.

Fixes: #756

Author: Chun-wei Fan
Author Date: 2022-12-16 08:47:12 UTC

Acquire the variants supported by a fontmap

This acquires the font features that are supported by a particular font,
and queries the font table to determine whether the variant is being supported.

Author: Bilal Elmoussaoui
Author Date: 2023-05-01 08:33:33 UTC

build: Bump version to 1.51.0

As the main branch contains deprecated functions since 1.52 causing rust bindings
to not be able to guard those changes behind a specific version in the CI.

Author: Khaled Hosny
Author Date: 2023-04-02 13:47:33 UTC

itemize: Improve script itemization

Merge marks, and other cluster extenders with the previous script. Logic
copied from:
https://searchfox.org/mozilla-central/rev/dbc0cd5615f9cd7337d3e05b7c3925af5f35c0ee/gfx/thebes/gfxScriptItemizer.cpp#113-122

Handling of script extensions is still missing as GLib does not seem to
have an API to retrieve it.

Fixes https://gitlab.gnome.org/GNOME/pango/-/issues/739

Author: Khaled Hosny
Author Date: 2023-03-05 08:21:40 UTC

testmatrix.c: Don’t use g_assert_cmphex() with floats

The build was giving this warning:
../tests/testmatrix.c:197:27: warning: implicit conversion from 'double' to 'guint64' (aka 'unsigned long long') changes value from 0.2 to 0 [-Wliteral-conversion]
  g_assert_cmphex (r, ==, 0.2);
  ~~~~~~~~~~~~~~~~~~~~~~~~^~~~

So the test was effectively comparing 0 to 0.

I switched to g_assert_cmpfloat(), but now the tests are failing as the
values don’t mach. I don’t know which is wrong, the expected value or
the code being tested.

Author: Matthias Clasen
Author Date: 2023-02-21 02:03:00 UTC

cairo: Don't mis-scale metrics

When metrics were ported to hb, we overlooked that
the scaling done by cairo on the base metrics is
no longer necessary. This was causing underlines
and strikethroughs to be too small when rendering
in a scaled context.

Thanks to Behdad for help in tracking this down.

Fixes: #730

Author: Matthias Clasen
Author Date: 2023-02-18 00:17:48 UTC

ci: Add new gi-docgen deps to the image

Author: Matthias Clasen
Author Date: 2023-02-04 14:24:42 UTC

Tweak backspace-deletes-character

Don't set this flag for math symbols, to
prevent symbols such as ≠ from 'splitting'
under backspace.

Author: Matthias Clasen
Author Date: 2023-01-29 21:46:59 UTC

Small speedup

Optimize the ASCII case here.

Author: Matthias Clasen
Author Date: 2023-01-15 16:00:55 UTC

pango-segmentation: Some tweaks

Allow showing word and sentence start/end too.

Author: Chun-wei Fan
Author Date: 2022-12-14 04:56:05 UTC

pangowin32-fontmap.c: Allow some support for loading custom fonts

Previously, when using GDI, we are able to add custom fonts to the system font
collection using AddFontResource()/AddFontResourceEx(), but this is not enough
as we transition to DirectWrite.

Allow some support for this for people that are using AddFontResource() (but
not yet AddFontResourceEx()), by using the GDI interop support in DirectWrite.

Let people know that currently AddFontResource() should be used for the moment
for this support to work, not AddFontResourceEx().

Author: Matthias Clasen
Author Date: 2022-12-13 17:56:26 UTC

Update test results

Newer harfbuzz in F37 changes this.

Author: Matthias Clasen
Author Date: 2022-12-13 14:25:42 UTC

build: Use a stable harfbuzz

We don't need the latest harfbuzz.
Stick to 4.0 for now.

Author: Matthias Clasen
Author Date: 2022-11-18 19:02:17 UTC

Fix char offset calculations

When dealing with multi-paragraph layouts,
the char offsets of the items are expected
to be relative to the beginning of the text,
not relative to the beginning of the current
paragraph.

This error was introduced in a03bf5bc6b07ba6e.

Fixes: #716

Author: Matthias Clasen
Author Date: 2022-11-18 19:02:17 UTC

Fix char offset calculations

When dealing with multi-paragraph layouts,
the char offsets of the items are expected
to be relative to the beginning of the text,
not relative to the beginning of the current
paragraph.

This error was introduced in a03bf5bc6b07ba6e.

Fixes: #716

Author: Matthias Clasen
Author Date: 2022-10-02 13:56:00 UTC

shape: Don't crash if log_attrs is NULL

We accept NULL for log_attrs, so we should not
crash when we are given NULL. While fixing this,
clarify the documentation of the various shaping
APIs for what they can and cannot do.

Related: !641

Author: Matthias Clasen
Author Date: 2022-09-27 00:41:19 UTC

Add a test for no-fonts

Test that the layout is made up entirely of unknown
glyphs if we have no font. The main point of this
test is to ensure that we don't crash if analysis->font
is NULL.

Author: Matthias Clasen
Author Date: 2022-09-11 00:08:06 UTC

layout: Fix indent and align handling

Make PangoLayout behavior more similar to the
way it behaved in pango 1.x. Most combinations
of alignment, indentation and width should work
the same now.

Author: Matthias Clasen
Author Date: 2022-09-07 02:38:46 UTC

layout: Fix line height computations

We were using the font metrics height, which is
scaled by the ctm, so we need to take the font
scale factors into account here.

Fixes: #691

Author: Matthias Clasen
Author Date: 2022-08-28 00:52:06 UTC

itemize: Use pango_font_get_variant

This avoids the unnecessary copy of the fonts
font description, just to extract the variant.

Author: Chun-wei Fan
Author Date: 2022-07-05 08:35:12 UTC

pangodwrite-fontmap: Add APIs to query font description from Windows fonts

Add 2 APIs for querying the Pango2FontDescription that corresponds to the
specified Windows LOGFONTW (GDI font) or IDWriteFont, largely using the
code that we already have in the DirectWrite support.

Notice that with the LOGFONTW path, we use DirectWrite's GDI interop to
acquire a IDWriteFont first and then go down the same (existing) route
as when we use a IDWriteFont, since it may be necessary to use LOGFONTW's
since Windows APIs such as SystemParametersInfoW() return LOGFONTW's
instead of IDWriteFont's, but DirectWrite has more fine-grained support
for font properties than GDI.

Author: Matthias Clasen
Author Date: 2022-07-04 14:56:42 UTC

0.91

Author: Matthias Clasen
Author Date: 2022-06-24 12:40:00 UTC

Fix handling of ligature carets in some cases

With a text of "ර් ", we were accidentally producing
a cursor position outside of the [start_xpos, end_xpos]
range, which clearly makes no sense.

Test included.

Fixes: #684

Author: Matthias Clasen
Author Date: 2022-06-23 13:31:06 UTC

Add a check for mixed linkage

Having both pango 1.x and pango 2 linked into
the same process will cause trouble, because the
type and function names conflict.

Error out if we detect this situation.

Author: Matthias Clasen
Author Date: 2022-06-10 21:50:04 UTC

cairotwisted: Fix another compiler warning

Author: Matthias Clasen
Author Date: 2022-06-10 15:55:02 UTC

Try again to fix ci

The rounding, it hurts...

Author: Matthias Clasen
Author Date: 2022-06-10 11:20:24 UTC

fc: Notify :n-items when needed

Notify :n-items when reloading the configuration,
since that may change the number of families.

Author: Matthias Clasen
Author Date: 2022-06-10 12:00:22 UTC

Update tests to pass on F36

Rounding differences are our downfall :(

Author: Matthias Clasen
Author Date: 2022-05-18 18:32:45 UTC

Optimize pango_utf8_make_valid

Avoid a separate g_utf8_strlen call.

Difference in layout-performance create-layout:
before: 1.1M layouts/s
after: 3.3M layouts/s

Author: Matthias Clasen
Author Date: 2022-04-13 01:44:18 UTC

itemize: Be more defensive

Let them have their NULL fonts.
Produce hexboxes without criticals.

Author: =?utf-8?b?TWlsb8WhIEtvbWFyxI1ldmnEhw==?=
Author Date: 2022-04-11 15:09:48 UTC

Apply 1 suggestion(s) to 1 file(s)

Author: Matthias Clasen
Author Date: 2022-03-31 06:19:45 UTC

Fix move pango_layout_move_cursor_visually

When moving the cursor off the paragraph end to
the left in RTL text, we were moving to the previous
line, and not to the next line, as expected.

Test included.

Fixes: #679

Author: Matthias Clasen
Author Date: 2022-03-19 04:20:30 UTC

1.50.6

Author: Matthias Clasen
Author Date: 2022-03-08 13:03:32 UTC

wip: add incremental reordering test

This needs us to build a libpango.a so we can link
tests statically, and test internal api.

Author: Matthias Clasen
Author Date: 2022-02-17 20:44:16 UTC

Update tests for script removal

Removing PangoScript changed the names we get for
scripts here.

Author: Matthias Clasen
Author Date: 2022-02-17 19:08:09 UTC

layout: Handle baselines

During post-processing for lines, take into
account the baselines for each run, and shift
them vertically to align them on the dominant
baseline.

Author: Matthias Clasen
Author Date: 2022-02-15 23:49:58 UTC

Use newer harfbuzz api

Use pango_ot_metrics_get_position_with_fallback,
where appropriate.

Author: Matthias Clasen
Author Date: 2022-02-15 14:04:36 UTC

Revert "Fix layout tests"

This reverts commit 053c9ff8ab00d6d7d4b7cbe8aeeaca58c0982df1.

Author: Matthias Clasen
Author Date: 2022-02-08 19:08:25 UTC

Add alpha to PangoColor

Adapt all users. This drops the alpha attributes
and alpha in markup, and adds alpha support to
underlines, overlines and strikethroughs.

Author: Matthias Clasen
Author Date: 2022-02-05 11:44:38 UTC

testhbfont: update for generic families

Author: Matthias Clasen
Author Date: 2022-02-13 19:19:45 UTC

wip: Add an api to select palettes for color glyphs

This commit adds a light-background attribute that can
be used to influence which palette will be used to render
COLRv0 layered glyphs with color fonts that have multiple
palettes. This needs a way for cairo to invalidate its
glyph cache when the selected palette changes, which
needs new freetype api.

Author: Matthias Clasen
Author Date: 2022-02-07 20:25:24 UTC

wip: Use hb-draw instead of freetype

Author: Matthias Clasen
Author Date: 2022-01-05 04:33:19 UTC

test-itemize: Leave out faceid

The faceid in the serialized font description would
make the test output backend-dependent, so leave it
out for now. This makes

PANGOCAIRO_BACKEND=fc2 ./test-itemize

succeed.

Author: Matthias Clasen
Author Date: 2022-01-26 03:25:57 UTC

layout: Go back to trimming start and end

We want the first and the last line of the paragraph
to have its leading trimmed, for the purposes of
determining the paragraph extents.

Author: Matthias Clasen
Author Date: 2022-01-21 03:06:32 UTC

Fix allow_breaks handling

handling of segmentation attributes can introduce
line breaks, after we removed them in allow_breaks
handling. Change the order to handle allow_breaks
last, so this doesn't happen.

Update affected tests.

Author: Matthias Clasen
Author Date: 2022-01-18 17:30:38 UTC

Fix a g_ascii_formatd call

We were passing a format specifier that starts
with ' ', which some implementations of that API
don't like.

This change removes an extraneous space from the
output. Update affected tests.

Fixes: #659

Author: Matthias Clasen
Author Date: 2022-01-14 16:19:35 UTC

Check for fontmaps

To avoid trivialities, check that our context
has a fontmap, at a strategic place.

Fixes: #658

Author: Matthias Clasen
Author Date: 2022-01-11 14:06:08 UTC

1.48.11

Author: Matthias Clasen
Author Date: 2022-01-10 14:53:22 UTC

Deprecate pango_coverage_ref/unref

These are just wrappers of g_object_ref/unref.

Author: Bilal Elmoussaoui
Author Date: 2022-01-08 08:17:49 UTC

g-i: add since annotations to enum members

Author: Matthias Clasen
Author Date: 2022-01-08 02:26:14 UTC

Reinstate previous behavior or pango_attr_list_splice

If gap is zero, don't limit the inserted attributes;
that does not make sense. Spell out the different
use cases in the docs.

Testcase included.

Fixes: #653

Author: Matthias Clasen
Author Date: 2021-09-11 16:44:29 UTC

Pass synthetic slant to harfbuzz

When our font matrix includes a slant, pass that information
to HarfBuzz, so it can adjust its mark positioning, metrics
like caret slope, etc.

This commit corrects the code that pulls the font matrix out
of fontconfig to properly take the flipped y axis between fontconfig
and pango into account.

Requires new api in HarfBuzz > 3.2

Author: Matthias Clasen
Author Date: 2021-12-25 14:48:17 UTC

Add fonts to installed tests

Fixes: #648

Author: Matthias Clasen
Author Date: 2021-12-24 05:43:48 UTC

fontsetsimple: Make privately accessible

This will be used in the future

Author: Matthias Clasen
Author Date: 2021-12-23 02:58:15 UTC

Make missing space smaller

The Microsoft paper I was citing actually recommends
1/4 em for ASCII space. Make it so...

Update affected tests.

Author: Matthias Clasen
Author Date: 2021-12-22 02:46:19 UTC

1.50.3

Author: Matthias Clasen
Author Date: 2021-12-21 19:53:16 UTC

Fix tests

Some rounding has somewhere.

Author: Matthias Clasen
Author Date: 2021-12-20 02:20:26 UTC

Pass synthetic slant to harfbuzz

This will let HarfBuzz adjust positioning
of marks and other things.

This requires new api HarfBuzz > 3.2.

Author: Matthias Clasen
Author Date: 2021-12-10 17:49:45 UTC

Fix line height with emulated small caps

When we change font scale for emulating small caps,
keep the original font around in the analysis, and use
it for calculating the run height.

Fixes: #622

Author: Matthias Clasen
Author Date: 2021-12-19 03:24:12 UTC

Add a test for the previous commits

This test verifies the fixes for the
situation described in #646.

Author: Matthias Clasen
Author Date: 2021-12-17 23:07:58 UTC

cairo: Work harder to measure space

When coming up with a width for a missing space,
we were just measuring the hex digits. But in
subsetted fonts, such as the ones we use for ci,
hex digits might well be missing. Take that into
account and still provide some nonzero width
for space.

Update affected tests.

Author: Matthias Clasen
Author Date: 2021-12-17 19:24:17 UTC

Revert "Fix advance widths with transforms"

This reverts commit ccb651dd2a876a4f4a4cb9351f05332173e709ba.

This broke vertical text rendering, see
https://gitlab.com/inkscape/inkscape/-/issues/2950.

Update affected tests and add a vertical test.

Author: Matthias Clasen
Author Date: 2021-12-17 18:05:05 UTC

pango-view: Add --serialize-to option

Add an option to produce a serialized output.

Author: Chun-wei Fan
Author Date: 2021-12-17 08:24:39 UTC

docs: Don't build pangoot bits if not enabled

PangoOT is actually a part of PangoFT2, so don't attempt to build its docs if
FontConfig is not found.

Author: Matthias Clasen
Author Date: 2021-12-16 13:40:07 UTC

Fix handling of space-less fonts

HarfBuzz knows how to synthesize spaces, we just
need to tickle it in the right way.

Test included.

Update affected tests.

Fixes: #641

Author: Matthias Clasen
Author Date: 2021-12-16 19:34:26 UTC

Add a test for 0x6dd

This tests the fix in the previous commit.

Author: Matthias Clasen
Author Date: 2021-12-16 13:12:24 UTC

Add a missing include

This was breaking the build on some macOs versions.

Fixes: #640

Author: Chun-wei Fan
Author Date: 2021-08-09 08:26:58 UTC

testmisc.c: Fix builds without FontConfig/PangoFT2

Some tests used items from PangoFT2, which may not have been enabled on
platforms where that was optionally built.

Author: Matthias Clasen
Author Date: 2021-12-11 22:10:41 UTC

Fix pango-view option handling

The --serialized option did not quite
work as expected.

Author: Matthias Clasen
Author Date: 2021-12-11 02:12:45 UTC

docs: Cosmetics

Add more links to GLib apis and to various
Unicode specs.

Author: Matthias Clasen
Author Date: 2021-12-10 16:57:39 UTC

ci: Rebase the image to Fedora 34

This gives us a newer meson, among other things.

Author: Matthias Clasen
Author Date: 2021-12-09 02:46:12 UTC

serializer: Use gtk_json_parser_select_string

Take advantage of the new parser api.

Author: Matthias Clasen
Author Date: 2021-12-08 13:04:01 UTC

Update affected tests

Author: Matthias Clasen
Author Date: 2021-12-05 15:45:52 UTC

Fix a crash in tab handling

When we uninsert the current tab run, we need to reset
our tab state to prevent last_tab->glyphs to become a
dangling pointer.

Test included.

Fixes: #634

Author: Matthias Clasen
Author Date: 2021-12-03 01:17:41 UTC

jsonparser: Plug a memory leak

Author: Matthias Clasen
Author Date: 2021-12-02 05:14:30 UTC

Fix up tab sizing

Author: Matthias Clasen
Author Date: 2021-11-29 12:30:43 UTC

Add a test with tab alignments