Media Hub

Merge lp:~vicamo/media-hub/add-lib64-for-64bit-android into lp:media-hub

  1. add-lib64-for-64bit-android
  2. Merge into trunk
Proposed by You-Sheng Yang
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 206
Merged at revision: 208
Proposed branch: lp:~vicamo/media-hub/add-lib64-for-64bit-android
Merge into: lp:media-hub
Diff against target: 34 lines (+12/-12)
1 file modified
debian/usr.bin.media-hub-server (+12/-12)
To merge this branch: bzr merge lp:~vicamo/media-hub/add-lib64-for-64bit-android
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
Review via email: mp+303652@code.launchpad.net

Commit message

Add /system/lib64 to apparmor permission rules

Description of the change

Currently we have only /system/lib etched in apparmor permission rules. On arm64, /system/lib64 is required. Example apparmor error:

kernel: [ 189.457372].(0)[7350:media-hub-serve]type=1400 audit(1471933369.640:152): apparmor="DENIED" operation="open" profile="/usr/bin/media-hub-server" name="/android/system/lib64/libmedia_compat_layer.so" pid=7350 comm="media-hub-serve" requested_mask="r" denied_mask="r" fsuid=32011 ouid=0

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/usr.bin.media-hub-server'
2--- debian/usr.bin.media-hub-server 2016-01-26 20:13:48 +0000
3+++ debian/usr.bin.media-hub-server 2016-08-23 07:03:56 +0000
4@@ -53,18 +53,18 @@
5 /usr/lib/@{multiarch}/libhybris/*.so mr,
6 /{,android/}system/build.prop r,
7 # These libraries can be in any of:
8- # /vendor/lib
9- # /system/lib
10- # /system/vendor/lib
11- # /android/vendor/lib
12- # /android/system/lib
13- # /android/system/vendor/lib
14- /{,android/}vendor/lib/** r,
15- /{,android/}vendor/lib/**.so m,
16- /{,android/}system/lib/** r,
17- /{,android/}system/lib/**.so m,
18- /{,android/}system/vendor/lib/** r,
19- /{,android/}system/vendor/lib/**.so m,
20+ # /vendor/lib{,64}
21+ # /system/lib{,64}
22+ # /system/vendor/lib{,64}
23+ # /android/vendor/lib{,64}
24+ # /android/system/lib{,64}
25+ # /android/system/vendor/lib{,64}
26+ /{,android/}vendor/lib{,64}/** r,
27+ /{,android/}vendor/lib{,64}/**.so m,
28+ /{,android/}system/lib{,64}/** r,
29+ /{,android/}system/lib{,64}/**.so m,
30+ /{,android/}system/vendor/lib{,64}/** r,
31+ /{,android/}system/vendor/lib{,64}/**.so m,
32
33 # attach_disconnected path
34 /dev/socket/property_service rw,

Subscribers

People subscribed via source and target branches