Merge lp:~vila/bzr/472161-ftp-utf8 into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~vila/bzr/472161-ftp-utf8 |
Merge into: | lp:bzr |
Diff against target: |
108 lines (+17/-16) 6 files modified
NEWS (+3/-0) bzrlib/osutils.py (+5/-3) bzrlib/tests/ftp_server/medusa_based.py (+2/-0) bzrlib/tests/ftp_server/pyftpdlib_based.py (+3/-2) bzrlib/tests/per_transport.py (+4/-0) bzrlib/transport/ftp/__init__.py (+0/-11) |
To merge this branch: | bzr merge lp:~vila/bzr/472161-ftp-utf8 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+16967@code.launchpad.net |
To post a comment you must log in.
This fix bug #472161 by... simply deleting _remote_path().
It also makes osutils. fancy_rename( ) more robust against uses with true unicode paths.
I'm not super proud of the trick to disable the unicode tests against medusa,
but I didn't want to make more involved changes for an ftp server that we
don't support with python >= 2.6.
I finally found RFC3640 which clearly states that Unicode paths are to be supported
as utf8-encoded by default.
The RFC mentions the FEAT command to ensure that the server supports UTF8 but I didn't
implement it to avoid the additional roundtrip (we'll find soon enough if UTF8 is not supported).
Feedback and real-world tests welcome !