Launchpad itself

Merge lp:~wallyworld/launchpad/project-cloud-title into lp:launchpad

  1. project-cloud-title
  2. Merge into devel
Proposed by Ian Booth
Status: Merged
Approved by: Paul Hummer
Approved revision: no longer in the source branch.
Merged at revision: 11524
Proposed branch: lp:~wallyworld/launchpad/project-cloud-title
Merge into: lp:launchpad
Diff against target: 25 lines (+2/-2)
2 files modified
lib/lp/code/stories/branches/xx-bazaar-home.txt (+1/-1)
lib/lp/code/templates/bazaar-index.pt (+1/-1)
To merge this branch: bzr merge lp:~wallyworld/launchpad/project-cloud-title
Reviewer Review Type Date Requested Status
Paul Hummer (community) ui Approve
Tim Penhey (community) Approve
Review via email: mp+34655@code.launchpad.net

Commit message

Change to heading text on lp code home page to indicate that the project tag cloud only contains a selection of active projects

Description of the change

Trivial change to heading text on lp code home page to indicate that the project tag cloud only contains a selection of active projects (not all of them as implied by the previous heading).

Tests:
   - lp/code/stories/branches/xx-bazaar-home.txt
   (modified existing doc test to check for correct page content)

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Perhaps "Most active projects in the last month"?

Revision history for this message
Ian Booth (wallyworld) wrote :

Change made as per below and pushed. I made the original change as per
the wording in the bug report :-)

On 06/09/10 19:13, Tim Penhey wrote:
> Perhaps "Most active projects in the last month"?

Revision history for this message
Tim Penhey (thumper) :
review: Approve
Revision history for this message
Ian Booth (wallyworld) wrote :

Screenshot of new title text:

https://devpad.canonical.com/~ianb/projectcloudtitle.png

Revision history for this message
Ian Booth (wallyworld) wrote :

Oops - wrong server. Use this one:

https://people.canonical.com/~ianb/projectcloudtitle.png

Revision history for this message
Paul Hummer (rockstar) :
review: Approve (ui)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/stories/branches/xx-bazaar-home.txt'
2--- lib/lp/code/stories/branches/xx-bazaar-home.txt 2010-08-27 04:53:51 +0000
3+++ lib/lp/code/stories/branches/xx-bazaar-home.txt 2010-09-06 21:22:46 +0000
4@@ -30,7 +30,7 @@
5
6 >>> preview = find_tag_by_id(browser.contents, 'project-cloud-preview')
7 >>> print extract_text(preview)
8- Projects with active branches
9+ Most active projects in the last month
10 see all projects…
11
12 >>> print preview.fetch('a')[-1]['href']
13
14=== modified file 'lib/lp/code/templates/bazaar-index.pt'
15--- lib/lp/code/templates/bazaar-index.pt 2010-07-12 14:48:32 +0000
16+++ lib/lp/code/templates/bazaar-index.pt 2010-09-06 21:22:46 +0000
17@@ -54,7 +54,7 @@
18 </p>
19
20 <div id="project-cloud-preview" tal:content="cache:public,6 hours">
21- <h2>Projects with active branches</h2>
22+ <h2>Most active projects in the last month</h2>
23 <a tal:repeat="product view/short_product_tag_cloud"
24 tal:attributes="href product/url;
25 class product/html_class;