Launchpad itself

Merge lp:~wgrant/launchpad/project-3.0-fixes into lp:launchpad

  1. project-3.0-fixes
  2. Merge into devel
Proposed by William Grant
Status: Rejected
Rejected by: Tim Penhey
Proposed branch: lp:~wgrant/launchpad/project-3.0-fixes
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~wgrant/launchpad/project-3.0-fixes
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Abstain
Review via email: mp+10225@code.launchpad.net
To post a comment you must log in.
Revision history for this message
William Grant (wgrant) wrote :

This fixes three trivial issues with the new project page, one of which will cause big problems when edge updates (an OOPS when a project has official_blueprints set). See the linked bugs for details.

Revision history for this message
Curtis Hovey (sinzui) wrote :

> This fixes three trivial issues with the new project page, one of which will
> cause big problems when edge updates (an OOPS when a project has
> official_blueprints set). See the linked bugs for details.

Hi William

Thanks for fixing these. My branch that I placed in review a few days ago fixed these and supersedes this approach. There is an underlying flaw to this first draft that I landed. It does not put the root site in the URL. It is not portable because the menus are not consistent for for all IPillars. Also, The approach does not work for IProject since it does not support official_* apps.

My branch adds a real menu and updated the view to normalise the portlet to work with IPillar, series, and sourcepackages.

Revision history for this message
Eleanor Berger (intellectronica) :
review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
2--- lib/canonical/launchpad/icing/style-3-0.css 2009-08-13 02:24:56 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css 2009-08-17 03:30:24 +0000
4@@ -556,11 +556,11 @@
5 }
6 .involvement a.code {
7 color: #d39f57;
8- background: url(/@@/images/code-arrow-right.png) right center no-repeat;
9+ background: url(/@@/code-arrow-right.png) right center no-repeat;
10 }
11 .involvement a.blueprint {
12 color: #5ba4c6;
13- background: url(/@@/images/blueprints-arrow-right.png) right center no-repeat;
14+ background: url(/@@/blueprints-arrow-right.png) right center no-repeat;
15 }
16
17 .announcements li {
18
19=== modified file 'lib/lp/registry/templates/pillar-involvement-portlet.pt'
20--- lib/lp/registry/templates/pillar-involvement-portlet.pt 2009-08-06 19:14:40 +0000
21+++ lib/lp/registry/templates/pillar-involvement-portlet.pt 2009-08-17 03:26:58 +0000
22@@ -8,7 +8,7 @@
23 <ul>
24 <li tal:condition="context/official_malone">
25 <a class="bugs"
26- tal:attributes="href context/menu:bugs/filebug/url">Report a Bug</a>
27+ tal:attributes="href context/menu:bugs/filebug/url">Report a bug</a>
28 </li>
29 <li tal:condition="context/official_answers">
30 <a class="question"
31@@ -24,7 +24,7 @@
32 </li>
33 <li tal:condition="context/official_blueprints">
34 <a class="blueprint"
35- tal:attributes="href context/menu:specications/new/url">Register a Blueprint</a>
36+ tal:attributes="href context/menu:specifications/new/url">Register a blueprint</a>
37 </li>
38 </ul>
39 </div>