libgrip

grip-test no longer responds to input

Bug #1168370 reported by Stephen M. Webb
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libgrip
Fix Released
Critical
Stephen M. Webb
libgrip 0.3.6
libgrip (Ubuntu)
Fix Released
High
Stephen M. Webb

Bug Description

[Impact]

 * The library was not supplying and gestures to client callers because of underlying change in the underlying gesture recognizer conflicting with an incorrect assumption in the libgrip library design. The assumption was that touch input device IDs were persistent across gesture recognizer instances, which has never been guaranteed to be true.

 * This bug renders the entire libgrip functionally useless, a fairly serious regression.

 * The bug fix moves to the latest version of the GEIS interface so obviates dependency on incorrect behaviour in the previous implementation.

[Test Case]

 * Using a touchscreen, invoke the eog photo viewer program and attempt to zoom a photo using the pinch gesture. Without this patch, there will be no response, with the patch the photo should zoom. See also #1120149.

[Regression Potential]

 * A programming error in the library could result in crashes in the eog or evince applications.

See original description

Related branches

lp:~bregma/libgrip/lp-1168370
PS Jenkins bot (community): Approve (continuous-integration)
Open Input Framework Team: Pending requested
Diff: 2145 lines (+703/-1177)
2 files modified
src/gripgesturemanager.c (+672/-1154)
src/gripinputdevice.c (+31/-23)
lp:~bregma/libgrip/lp-1168370-raring
PS Jenkins bot (community): Approve (continuous-integration)
Marco Trevisan (Treviño): Approve
Diff: 2144 lines (+702/-1177)
2 files modified
src/gripgesturemanager.c (+671/-1154)
src/gripinputdevice.c (+31/-23)
lp:ubuntu/raring-proposed/libgrip
Revision history for this message
Stephen M. Webb (bregma) wrote :

The geisview tool gives unexpected errors when run with debug output enabled. See attached file.

Changed in geis:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Stephen M. Webb (bregma)
Revision history for this message
Stephen M. Webb (bregma) wrote :

Running the grip-test tool with debug logging enabled shows a lack of expected device matches: both devices recognized as present should match a "Pinch,touch-2" gesture.

Changed in geis (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Stephen M. Webb (bregma)
Revision history for this message
Stephen M. Webb (bregma) wrote :

Looks like the problem is that libgrip is assuming all GEIS instances return the same device ID for the same device. It's an invalid assumption. Device IDs are only valid within an instance.

Revision history for this message
Stephen M. Webb (bregma) wrote :

Problem in comment #1 appears to be unrelated: reported as bug #1169249.

Stephen M. Webb (bregma)
Changed in libgrip:
status: Triaged → In Progress
Stephen M. Webb (bregma)
Changed in libgrip:
milestone: none → 0.3.6
no longer affects: geis
no longer affects: geis (Ubuntu)
Changed in libgrip (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Stephen M. Webb (bregma)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:libgrip at revision 77, scheduled for release in libgrip, milestone 0.3.6

Changed in libgrip:
status: In Progress → Fix Committed
Stephen M. Webb (bregma)
Changed in libgrip:
importance: High → Critical
Stephen M. Webb (bregma)
description: updated
Changed in libgrip (Ubuntu Raring):
importance: Undecided → High
Stephen M. Webb (bregma)
description: updated
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:libgrip/raring at revision 76, scheduled for release in libgrip, milestone raring-sru-0

Stephen M. Webb (bregma)
Changed in libgrip:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libgrip - 0.3.6daily13.06.05-0ubuntu1

---------------
libgrip (0.3.6daily13.06.05-0ubuntu1) saucy; urgency=low

  [ Stephen M. Webb ]
  * bumping to version 0.3.6

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 81

libgrip (0.3.6daily13.05.29ubuntu.unity.next-0ubuntu1) raring; urgency=low

  [ Stephen M. Webb ]
  * bumping to version 0.3.6

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 80 (ubuntu-unity/next)

libgrip (0.3.6daily13.05.17ubuntu.unity.next-0ubuntu1) raring; urgency=low

  * Automatic snapshot from revision 78 (ubuntu-unity/next)

libgrip (0.3.6daily13.05.13-0ubuntu1) raring; urgency=low

  [ Stephen M. Webb ]
  * installs grip-test to debian/tmp (LP: #1082214)
  * grip-test no longer responds to input (LP: #1168370)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 77
 -- Ubuntu daily release <email address hidden> Wed, 05 Jun 2013 02:02:11 +0000

Changed in libgrip (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Stephen, or anyone else affected,

Accepted libgrip into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libgrip/0.3.6daily13.06.19~13.04-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libgrip (Ubuntu Raring):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

0.3.6daily13.06.10-0ubuntu1 <- saucy
0.3.6daily13.06.19~13.04-0ubuntu1 <- raring-proposed

The version string used for an SRU is higher than the released version in saucy, which doesn't seem right.

Revision history for this message
Sebastien Bacher (seb128) wrote :

That update makes eog segfault on start when run without argument, marking the bug as verification-failed ... can we get it rejected from the proposed serie? The same bug was in saucy and fixed recently, that fix should probably be backported to the raring serie as well

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote :

Removing packages from raring-proposed:
 libgrip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
Comment: Failed SRU verification
Remove [y|N]? y
1 package successfully removed.

Stephen M. Webb (bregma)
no longer affects: libgrip/raring
no longer affects: libgrip (Ubuntu Raring)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.