Ubuntu
python-novaclient package

[SRU] Fix Typo in socket attribute name in TCPKeepAliveAdapter

Bug #1499510 reported by Bryan Quigley
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Fix Released
High
Unassigned
Kilo
Fix Released
High
Unassigned
python-novaclient (Ubuntu)
Fix Released
High
Unassigned
Vivid
Fix Released
High
Bryan Quigley

Bug Description

[Impact]

When using connection_pool=True in a python-novaclient instance, some operations will fail. For more details, see upstream bug: https://bugs.launchpad.net/python-novaclient/+bug/1430935

#1430935 Typo in socket attribute name in TCPKeepAliveAdapter High David Moreau Simard Fix Released
-from https://launchpad.net/python-novaclient/+milestone/2.23.0

Ubuntu 14.04 with Kilo Cloud Archive..

I have a debdiff that just fixes the typo. Alternative is to just upgrade to 15.10 or Libery Cloud Archive.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: python-novaclient 1:2.22.0-0ubuntu1~cloud0 [origin: Canonical]
ProcVersionSignature: User Name 3.13.0-63.103-generic 3.13.11-ckt25
Uname: Linux 3.13.0-63-generic x86_64
ApportVersion: 2.14.1-0ubuntu3.15
Architecture: amd64
CrashDB:
 {
                "impl": "launchpad",
                "project": "cloud-archive",
                "bug_pattern_url": "http://people.canonical.com/~ubuntu-archive/bugpatterns/bugpatterns.xml",
             }
Date: Thu Sep 24 19:39:14 2015
Ec2AMI: ami-00000f4d
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: m1.tiny
Ec2Kernel: aki-00000548
Ec2Ramdisk: ari-00000548
PackageArchitecture: all
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: python-novaclient
UpgradeStatus: No upgrade log present (probably fresh install)

[Test Case]

See accompanying patch for test case.

[Regression Potential]

Very little regression potential as the fix is a simple typo fix.

See original description
Revision history for this message
Bryan Quigley (bryanquigley) wrote :
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Hmm... I'm not sure the proper way to back-port the whole minor release.

This backports the typo from bug #1430935 and related test.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "python-novaclient_2.22.0-0ubuntu2.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Issue resolved by upgrading to 15.10. If anyone else wants this one fix backported, mention it and I'll see about a proper SRU..

summary: - In Kilo Upgrade python-novaclient to 2.23
+ Fix Typo in socket attribute name in TCPKeepAliveAdapter
description: updated
Michael Terry (mterry)
Changed in python-novaclient (Ubuntu):
status: New → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote : Re: Fix Typo in socket attribute name in TCPKeepAliveAdapter

Bryan I'd prefer to split this into two bugs/SRUs.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Note that bug #1431154 does have a work-around (see upstream bug) so we might consider marking that with medium importance if it is split into a separate bug.

Changed in cloud-archive:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

alright I'm happy to just have this one be the TCPKeepAlive typo.

I noticed a bit of extra text in the debdiff so I removed that, otherwise it was only fixing the typo bug anyway.

description: updated
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Bryan. Would you mind updating the debdiff with unchanged cherry picks from upstream's stable/kilo branch? Then we'll end up with 2 patches that are inline with upstream:
git format-patch -1 689a884e~1 689a884e
git format-patch -1 8c0baaea~1 8c0baaea

Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Separated them based on upstream. Is that what you were looking for?

Revision history for this message
Bryan Quigley (bryanquigley) wrote :

With headers left in place. Thanks for your help coreycb!

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Bryan! The patch looks good. Just working on merging it now.

Corey Bryant (corey.bryant)
Changed in python-novaclient (Ubuntu):
importance: Undecided → High
status: Fix Released → Invalid
no longer affects: cloud-archive
no longer affects: cloud-archive/kilo
Corey Bryant (corey.bryant)
Changed in python-novaclient (Ubuntu Vivid):
status: New → Fix Committed
importance: Undecided → High
Changed in python-novaclient (Ubuntu):
importance: High → Undecided
Corey Bryant (corey.bryant)
Changed in python-novaclient (Ubuntu Vivid):
assignee: nobody → Bryan Quigley (bryanquigley)
Corey Bryant (corey.bryant)
summary: - Fix Typo in socket attribute name in TCPKeepAliveAdapter
+ [SRU] Fix Typo in socket attribute name in TCPKeepAliveAdapter
Corey Bryant (corey.bryant)
description: updated
description: updated
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Bryan, or anyone else affected,

Accepted python-novaclient into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-novaclient/1:2.22.0-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Mathew Hodson (mhodson) wrote :

This is fixed in Wily and later.

Changed in python-novaclient (Ubuntu):
importance: Undecided → High
status: Invalid → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Bryan, this is also available in the cloud-archive if you'd like to test:

sudo add-apt-repository cloud-archive:kilo-proposed

Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Quick test indicates this error no longer comes up.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-novaclient - 1:2.22.0-0ubuntu2

---------------
python-novaclient (1:2.22.0-0ubuntu2) vivid; urgency=medium

  * d/p/Fix-typo-in-socket-attribute-name.patch,
    d/p/Add-a-test-for-the-TCPKeepAliveAdapter.patch: Fix Typo in socket
    attribute name in TCPKeepAliveAdapter and add test (LP: #1499510)

 -- Bryan Quigley <email address hidden> Tue, 10 Nov 2015 17:30:19 +0000

Changed in python-novaclient (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for python-novaclient has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
James Page (james-page) wrote :

Promoted to -updates for Kilo UCA.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.