disco dist-upgrader tarball has a broken symlink in it

I was able to recreate this by just touching /var/snap/canonical-livepatch/common/machine-token after creating the directory in which the file exists.

Hello Steve, or anyone else affected,

Accepted ubuntu-release-upgrader into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:19.04.16.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I followed the test case from the bug description and no longer received the message regarding livepatch being disabled. Additionally inspecting the downloaded dist-upgrader tarball we can see that the symlink is now good.

bdmurray@clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ file DistUpgrade
DistUpgrade: broken symbolic link to DistUpgrade
bdmurray@clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ cat DistUpgradeVersion.py
VERSION = '19.04.16.1'
bdmurray@clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ cd -
/tmp/ubuntu-release-upgrader-27u554bb
bdmurray@clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-27u554bb$ file DistUpgrade
DistUpgrade: symbolic link to .
bdmurray@clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-27u554bb$ cat DistUpgradeVersion.py
VERSION = '19.04.16.2'

Setting to verification-done.

This bug was fixed in the package ubuntu-release-upgrader - 1:19.04.16.2

---------------
ubuntu-release-upgrader (1:19.04.16.2) disco; urgency=medium

  * Fix broken symbolic link of DistUpgrade/DistUpgrade which caused code from
    the installed ubuntu-release-upgrader to be used instead of code in the
    dist-upgrader tarball. (LP: #1824430)

 -- Brian Murray <email address hidden> Thu, 25 Apr 2019 08:22:50 -0700

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package ubuntu-release-upgrader - 1:19.10.1

---------------
ubuntu-release-upgrader (1:19.10.1) eoan; urgency=medium

  * DistUpgrade/{EOL,Devel}ReleaseAnnouncement,
    DistUpgrade/window_main.ui,
    data/gtkbuilder/DistUpgrade.ui,
    data/DistUpgrade.cfg,
    pre-build.sh:
    - updated for 19.04 -> 19.10
  * data/DistUpgrade.cfg.bionic,
    data/demoted.cfg.bionic,
    pre-build.sh:
    - support upgrades from bionic (LP: #1827635)
  * data/removal_blacklist.cfg: add blacklist entry for postgresql versions
    with two major digits e.g. postgresql-11. (LP: #1825563)
  * Fix broken symbolic link of DistUpgrade/DistUpgrade which caused code from
    the installed ubuntu-release-upgrader to be used instead of code in the
    dist-upgrader tarball. (LP: #1824430)

 -- Brian Murray <email address hidden> Fri, 03 May 2019 10:24:48 -0700