Other Software > Remove button doesn't work

After racking my brains thinking this had to do with deb822, I found that a Dbus exception was being suppressed by only logging one particular exception. Disabling the catch with

--->
    def on_remove_clicked(self, widget):
        """Remove the selected source"""
        model = self.treeview_sources.get_model()
        (path, column) = self.treeview_sources.get_cursor()
        iter = model.get_iter(path)
        if iter:
            source_entry = model.get_value(iter, LIST_ENTRY_OBJ)
            #try:
            self.backend.RemoveSource(str(source_entry))
            #except dbus.DBusException as e:
            # maybe_log_authentication_canceled_error(e)
<---

reveals the issue:

--->
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 1159, in on_remove_clicked
    self.backend.RemoveSource(str(source_entry))
  File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/dbus/connection.py", line 634, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dbus.exceptions.DBusException: com.ubuntu.SoftwareProperties.PermissionDeniedByPolicy: com.ubuntu.softwareproperties.applychanges
<---

I had killed the authentication agent and forgot to bring it back, so my last comment conclusion is wrong.

The incorrect behavior does seem to be tied to deb822; for .source files the exception being suppressed is

--->
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 1158, in on_remove_clicked
    self.backend.RemoveSource(str(source_entry))
  File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/dbus/connection.py", line 634, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dbus.exceptions.DBusException: org.freedesktop.DBus.Python.ValueError: Traceback (most recent call last):
  File "/lib/python3/dist-packages/dbus/service.py", line 712, in _message_cb
    retval = candidate_method(self, *args, **keywords)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3/dist-packages/softwareproperties/dbus/SoftwarePropertiesDBus.py", line 285, in RemoveSource
    self.remove_source(_to_unicode(source))
  File "/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 779, in remove_source
    self.remove_source(source, True)
  File "/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 781, in remove_source
    self.remove_source(source, False)
  File "/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 802, in remove_source
    self.sourceslist.list.append(SourceEntry("", file=source.file))
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3/dist-packages/aptsources/sourceslist.py", line 509, in __init__
    raise ValueError("Classic SourceEntry cannot be written to .sources file")
ValueError: Classic SourceEntry cannot be written to .sources file
<---

Ubuntu sponsors: Patch[1] is available from linked merge request.

[1] https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/463870/+preview-diff/1051432/+files/preview.diff

Hello Nathan,

the diff LGTM, I just have two questions:

1. The bug description has a "test case", but that's more of a reproducer than of a test case, right? The "expected result" is not explicitly stated. In particular, looking at this step:

 - After Authentication, nothing happens.

what should happen instead? And, on:

  The repo line still shows.
  The repo is still in /etc/apt/sources.list.d/

the expected behavior is that the repo is gone, right?

Can you please make this more explicit and state that you actually verified the fix that way?

Thanks!

Hi Paride, thanks for having a look.

I'm not the reporter of the bug, but yes I'd also call that a reproducer.

The expected behavior is that, after authentication,

(1) it is immediately gone from software properties and
(2) Apt no longer pulls from that repository: 'apt update --print-uris' no longer reports the just removed repository because the corresponding file in is /etc/apt/sources.list.d/ is either gone or empty.

...And I verified the fix in that way.

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading software-properties_0.99.47.dsc: done.
  Uploading software-properties_0.99.47.tar.xz: done.
  Uploading software-properties_0.99.47_source.buildinfo: done.
  Uploading software-properties_0.99.47_source.changes: done.
Successfully uploaded packages.

This looks like a good fix to have for 24.04 release but does not look beta-critical.

This bug was fixed in the package software-properties - 0.99.47

---------------
software-properties (0.99.47) noble; urgency=medium

  * Fix failed removal of Deb822 formated source in "Other Software" tab
    (LP: #2059796).

 -- Nathan Pratta Teodosio <email address hidden> Tue, 09 Apr 2024 09:02:50 +0200