conf: DEFAULT_RUNLEVEL should not be assigned if nothing found from /etc/inittab

I believe Johan had a neater patch for this?

Patch attached. I didn’t test it on a live system, though. (I did test the sed expression with various inputs under dash.)

Fix committed to trunk: http://bazaar.launchpad.net/~scott/upstart/trunk/revision/1210

Fix committed to 0.6; http://bazaar.launchpad.net/~scott/upstart/0.6/revision/1206

Thanks for the bug fixed. However, the code in the http://bazaar.launchpad.net/~scott/upstart/0.6/revision/1206 will _REPLACE_ the DEFAULT_RUNLEVEL even if /etc/inittab is something like:
#id:3:initdefault:
i.e. a commented line beginning with "#".
Maybe it's better to make it like:
eval "$(sed -nre 's/^[^#][^:]+:([0-6sS]):initdefault:.*/DEFAULT_RUNLEVEL="\1";/p' inittab || true)"

I believe you have better way to write it.
My 2 cents.

On Sun, 2009-08-30 at 03:05 +0000, steven_shiau wrote:

> Thanks for the bug fixed. However, the code in the http://bazaar.launchpad.net/~scott/upstart/0.6/revision/1206 will _REPLACE_ the DEFAULT_RUNLEVEL even if /etc/inittab is something like:
> #id:3:initdefault:
> i.e. a commented line beginning with "#".
> Maybe it's better to make it like:
> eval "$(sed -nre 's/^[^#][^:]+:([0-6sS]):initdefault:.*/DEFAULT_RUNLEVEL="\1";/p' inittab || true)"
>
> I believe you have better way to write it.
> My 2 cents.
>
Could you open a new bug about that?

It probably needs to be

 ^[^#][^:]*:

Since I think 1-character ids are acceptable to sysvinit

Scott
--
Scott James Remnant
<email address hidden>

Oh, sorry, my bad - this doesn't need a new bug as this one's still open! :)

Have updated the regex in trunk

This bug was fixed in the package upstart - 0.6.3-8

---------------
upstart (0.6.3-8) karmic; urgency=low

  * Rather than calling "telinit u" after upgrade, which will lose state,
    have the umountroot initscript take care of it for us by setting a
    flag. LP: #441796.
  * Don't lose the original default runlevel if /etc/inittab exists without
    an initdefault line. LP: #405847.
  * Fix "unhandled error" in shutdown when unable to change runlevel,
    e.g. due to previous Ubiquity bug. LP: #426332.
  * Merge change from trunk that makes it possible to build Upstart using
    a previously built copy of nih-dbus-tool, especially useful when
    cross-compiling. LP: #426740.
  * Merge change from libnih to store our assertion messages in the
    glibc __abort_msg symbol so apport can pick them up. LP: #429411.
  * Merge change from libnih to fix compilation issue with eglibc due
    to changed alphasort() prototype.

 -- Scott James Remnant <email address hidden> Wed, 14 Oct 2009 05:34:13 +0100

0.6.5 2010-02-04 "Our last, best hope for victory"

 * Since libnih has been separated out into its own project, Upstart
   no longer includes its source and now uses the installed version by
   default.

 * The external nih-dbus-tool means that cross-compilation is trivial,
   the path to it may be overriden with NIH_DBUS_TOOL=... as an
   argument to configure. (Bug: #426740)

 * Developers may still build against a local libnih source tree by
   passing --with-local-libnih=/path/to/libnih to configure.

 * There is a new initctl "reload" command, with matching
   /sbin/reload symlink. This sends the SIGHUP signal to the running
   main process of the named job instance.

 * Event operator matches in jobs now support "!=" in addition to the
   usual "=", e.g.:

  start on net-device-added INTERFACE!=eth*

   (Bug: #513035)

 * Moved D-Bus system bus reconnection trigger from SIGHUP to SIGUSR1,
   since SIGHUP is already used for a forced configuration reload and
   causes Upstart to "forget" state.

 * Fixed bug where the default runlevel would be lost when an
   /etc/inittab file exists without an initdefault line. (Bug: #405847)

 * Fixed "Unhandled error" message from shutdown. (Bug: #426332)

 * Fixed "Unhandled error" assertion crash from Upstart child
   processes when failing to spawn a job. (Bug: #451917)

 * No longer holds /dev/console open, so the SAK SysRq key will not
   kill Upstart. (Bug: #486005)

 * Restored sync() call before reboot().

 * Added missing OPTIONS section to init(8) manpage. (Bug: #449883)