Status bar doesn't say "___ matching items" for search results

Bug #426252 reported by Matthew Paul Thomas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

software-store trunk r181, Ubuntu Karmic

1. From a section where searching is possible, enter some search text that returns matching results.
2. Look at the status bar:

What you see: Text of the form "15 items available".

What you should see: Text of the form "15 matching items". <https://wiki.ubuntu.com/SoftwareStore#Search%20results>

It may save time to fix bug 425876 at the same time as this bug.

Tags: bitesize
Michael Vogt (mvo)
Changed in software-store (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
István Nyitrai (sianis) wrote :
Revision history for this message
Andrew (and471) wrote :

Fixed in my branch

Changed in software-store (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
István Nyitrai (sianis) wrote :

Here is a better patch.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

István, that patch changes the status bar text for the lobby screen and department screens too, which is inappropriate. We want the "matching items" text only when showing search results.

It looks to me like the underlying problem is that the status text is defined globally in app.py, when it should be defined separately for separate sections.

* The "Get Free Software" lobby and department screens should have status text of the form "2173 applications available".
  <https://wiki.ubuntu.com/SoftwareStore#Lobby%20screen>
  <https://wiki.ubuntu.com/SoftwareStore#Department%20screen>

* The "Installed Software" main screen should have status text of the form "204 applications installed".
  <https://wiki.ubuntu.com/SoftwareStore#%E2%80%9CInstalled%20Software%E2%80%9D%20section>

* Regardless of section, search results should override the status bar text to be of the form "37 matching items".
  <https://wiki.ubuntu.com/SoftwareStore#Search%20results>

description: updated
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Sorry, I wrote that comment looking at the first version of the patch. The second version is better, though I'm still doubtful about the appropriateness of defining all status bar text formats in a single place. Bug 425876 and bug 432218 make me think they should instead be defined in the code for the relevant Store section.

Revision history for this message
Michael Vogt (mvo) wrote :

Setting to confirmed again, the initial fix is not sufficient. I have a look at the second one today.

Changed in software-store (Ubuntu):
status: Fix Committed → Confirmed
Revision history for this message
István Nyitrai (sianis) wrote :

Hi!

Here is an other way of handling texts on status_bar. It is more abstract and easily maintainable. Let me know your opinions.

Michael Vogt (mvo)
Changed in software-store (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-store - 0.3.7

---------------
software-store (0.3.7) karmic; urgency=low

  * i18n fixes, thanks to Istvan Nyitrai
  * code cleanup
  * show different status bar label based on if it is a search
    or a not (LP: #426252) - thanks to István Nyitrai
  * Show empty status bar on viewing details, thanks to
    István Nyitrai LP: #425876
  * fix crash when clicking "Install" (LP: #432645)
  * add border around navigation pane (LP: #433520)
  * do not raise if entering the password takes too long (LP: #432704)
  * softwarestore/view/appview.py:
    - fix bug in on_iter_nth_child()
  * when a transaction is triggered and there is no other transaction
    already queued, jump to the "in progress" view (LP: #426257)
  * Fix usage of "Pending" to "In progress" (LP: #434088)
  * softwarestore/view/appdetailsview.py:
    - use aptdaemons {install,upgrade,remove}_packages instead
      of commit_packages

 -- Michael Vogt <email address hidden> Mon, 21 Sep 2009 17:50:10 +0200

Changed in software-store (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.