Empathy notification preferences not honored by indicator-messages

If anyone could give me a pointer to where I can look to correct the problem, I wouldn't mind fixing up a patch myself.

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please execute the following command, as it will automatically gather debugging information, in a terminal:

apport-collect 533857

This will help us to find and resolve the problem. Bear in mind that you may need to install the python-launchpadlib package from the universe repository. Additionally, when prompted to give apport-collect permissions for Launchpad you will need to give it at least the ability to "Change Non-Private" data as it will be adding information to your bug report. Thanks in advance!

When reporting bugs in the future please use apport, either via the appropriate application's "Help -> Report a Problem" menu or using 'ubuntu-bug' and the name of the package affected. You can learn more about this functionality at https://wiki.ubuntu.com/ReportingBugs.

On Fri, 2010-04-02 at 21:42 +0000, Sune Keller wrote:
> If anyone could give me a pointer to where I can look to correct the
> problem, I wouldn't mind fixing up a patch myself.

This would be in the indicator patch to Empathy. If you do:

   bzr branch lp:ubuntu/empathy

Then you'll find the patch in
empath/debian/patches/20_libindicate.patch. I'm not very familiar with
the patch, but I'd probably start from indicate_indicator_new() and work
back from there :)

This hack should fix the problem. It checks whether the relevant preference is true before showing indicator. I don't have experience applying all the patches and building the package, so I don't even know if it compiles.

Any help?

apport information

apport information

Running apport-collect 533857 returns "No additional information to collect", but using "-p empathy" after that instead gives the following output:

Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `GtkTreeView::indent-expanders' of type `gboolean' from rc file value "((GString*) 0xae07b60)" of type `GString'

Anyway, it's not a crash and there's therefore no stack trace to be found.
It was easy to locate the function in which the preference should be checked, and I've tried one way of doing it, inspired by a similar check in Empathy's own code (whether to add an event to Empathy's event manager about the contact logging in).

I've checked that the header file relevant to fetching preferences is included in the file that empathy/debian/patches/20_libindicate.patch adds (src/empathy-indicator-manager.c), so if anyone can give me a hint as to how to compile empathy including the patches, I could make a debdiff.

Or shall I create a branch and propose it for merging? How do I do that?

This bug was fixed in the package empathy - 2.30.0.1-0ubuntu1

---------------
empathy (2.30.0.1-0ubuntu1) lucid; urgency=low

  * New upstream version
    - empathy crashed with SIGSEGV in g_closure_invoke() (LP: #527296)
    - contact list is empty for a jabber account with a lot of
      contacts (LP: #539023)
    - Join room should be greyed out for AIM (LP: #540525)
    - Previous/Next Tab menu items aren't disabled if at the first/last tab
      and gtk-keynav-wrap-around is 0
    - empathy incorrectly updates our own IRC nick for /me
    - Shouldn't request RoomList channel if not supported by connection
    - account-chooser crashes when setting a filter and has-all-option to TRUE
    - empathy crashed with SIGSEGV in g_object_unref() (LP: #556977)
    - Wrong account name when using the assistant
    - Empathy fails to initiate a audio/video call over XMPP
  * debian/patches/20_libindicate.patch
    - Ported patch to remove NotificationData, removed upstream
  * debian/patches/32_append_notifications.patch
    - Ported patch to remove NotificationData, removed upstream
  * debian/patches/21_login_indicators.patch
    - Only display indicator for signon events if the preference
      is set (LP: #533857)
 -- Ken VanDine <email address hidden> Fri, 09 Apr 2010 15:07:58 -0400