the appindicator patch to g-s-d breaks compilation for appindicator-less case

Bug #666806 reported by Maciej Katafiasz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Fix Released
Low
Rodrigo Moya

Bug Description

Binary package hint: gnome-settings-daemon

As of 2.32.0-0ubuntu3, the automake-fu, as listed on https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators#Automake%20fu, has been applied wrongly, for no visible reason. Namely, the original bit:

AC_ARG_ENABLE(appindicator,
                        AS_HELP_STRING([--enable-appindicator[=@<:@no/auto/yes@:>@]],[Build support for application indicators ]),
                        [enable_appindicator=$enableval],
                        [enable_appindicator="auto"])

has been instead changed to:

AC_ARG_ENABLE([appindicator],
 AS_HELP_STRING([--enable-appindicator[=@<:@no/auto/yes@:>@]],[Build support for application indicators]),
 [enable_appindicator="yes"],
 [enable_appindicator="auto"])

Due to the way automake snippets are expanded and organised, this has the effect of ignoring the actual value supplied to --enable-appindicator and always substituting "yes" instead. The original form of '[enable_appindicator=$enableval]' should be restored to fix it.

Related branches

summary: - [Maverick] APPINDICATOR automake-fu is broken
+ [Maverick] appindicator patch to g-s-d breaks compilation for
+ appindicator-less case
Revision history for this message
Maciej Katafiasz (mathrick) wrote : Re: [Maverick] appindicator patch to g-s-d breaks compilation for appindicator-less case

Additionally, the 06_use_application_indicator.patch omits #ifdefs around one chunk of appindicator-specific code, breaking the compilation for --enable-appindicator=no. The attached diff is a patch to that patch, fixing both problems reported.b

summary: - [Maverick] appindicator patch to g-s-d breaks compilation for
- appindicator-less case
+ the appindicator patch to g-s-d breaks compilation for appindicator-less
+ case
Changed in gnome-settings-daemon (Ubuntu):
importance: Undecided → Low
Changed in gnome-settings-daemon (Ubuntu):
assignee: nobody → Rodrigo Moya (rodrigo-moya)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.32.1-0ubuntu7

---------------
gnome-settings-daemon (2.32.1-0ubuntu7) natty; urgency=low

  [ Maciej Katafiasz ]
  * debian/patches/06_use_application_indicator.patch:
    - Fix building without appindicators (LP: #666806)
 -- Rodrigo Moya <email address hidden> Fri, 25 Feb 2011 11:01:25 +0100

Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.