Ubuntu
firefox package

FTBFS on armel

Bug #696895 reported by Jani Monoses
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Fix Released
High
Micah Gersten
Natty
Fix Released
High
Micah Gersten
xulrunner-2.0 (Ubuntu)
Fix Released
High
Micah Gersten
Natty
Fix Released
High
Micah Gersten

Bug Description

Binary package hint: firefox

Latest firefox (and xulrunner-2.0) packages FTBFS in natty because they are built with -march=armv5te and some ASM code is incompatible with that.
Adding the line
ac_add_options --enable-thumb2
to debian/mozconfig.in fixes the build (it correctly passes -march=armv7-a to gcc)

Micah Gersten (micahg)
Changed in firefox (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
importance: Undecided → High
status: New → In Progress
Changed in xulrunner-2.0 (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0~b8+nobinonly-0ubuntu2

---------------
firefox (4.0~b8+nobinonly-0ubuntu2) natty; urgency=low

  * fix LP: #696895 - FTBFS on armel; Add --enable-thumb2 to build for armv7;
    Thanks to Jani Monoses for the fix
    - update debian/mozconfig.in
    - update debian/rules
 -- Micah Gersten <email address hidden> Mon, 03 Jan 2011 22:44:12 -0600

Changed in firefox (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

Reopening, since my fix didn't work.

Changed in firefox (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Jani Monoses (jani) wrote :

--enable-thumb2 option was not passed

this is also needed somewhere in debian/rules to actually pass it to the script generating mozconfig from mozconfig.in

ifeq (1, $(DEB_ENABLE_THUMB2))
        DEB_DEFINES += -DDEB_ENABLE_THUMB2
endif

I have only tested yesterday adding the --enable-thumb2 line unconditionally in the packaging, as it only has effect on ARM in upstream's configure file. It is not directly passed to gcc so that should be fine.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0~b8+nobinonly-0ubuntu3

---------------
firefox (4.0~b8+nobinonly-0ubuntu3) natty; urgency=low

  [ Chris Coulson <email address hidden> ]
  * Fix LP: #694391 - firefox-branding (rather than firefox) should
    replace kubuntu-firefox-installer
    - update debian/control.pp

  [ Micah Gersten <email address hidden> ]
  * Really fix LP: #696895 - FTBFS on armel; Add DEB_ENABLE_THUMB2 to
    DEB_DEFINES so thumb2 is actually enabled; Thanks to Jani Monoses for the
    fix
    - update debian/rules
  * Define the default for DEB_ENABLE_THUMB2 with the rest of the defaults
    - update debian/rules
 -- Micah Gersten <email address hidden> Wed, 05 Jan 2011 13:50:56 -0600

Changed in firefox (Ubuntu Natty):
status: In Progress → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

bzr commit -m '* fix LP: #696895 - FTBFS on armel; Add DEB_ENABLE_THUMB2 to debian/rules to
  add --enable-thumb2 to mozconfig only on arm to build for armv7
  - update debian/rules
  - update debian/mozconfig.in' --fixes 'lp:696895'

Changed in xulrunner-2.0 (Ubuntu Natty):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xulrunner-2.0 - 2.0~b9+build1+nobinonly-0ubuntu1

---------------
xulrunner-2.0 (2.0~b9+build1+nobinonly-0ubuntu1) natty; urgency=low

  * New upstream release v2.0 B9 (FIREFOX_4_0b9_BUILD1)

  [ Micah Gersten <email address hidden> ]
  * Bump minimum system sqlite to 3.7.3 after upstream landing of (bmo: 598306)
    aka Upgrade to SQLite 3.7.3
    - update debian/rules
  * fix LP: #696895 - FTBFS on armel; Add DEB_ENABLE_THUMB2 to debian/rules to
    add --enable-thumb2 to mozconfig only on arm to build for armv7
    - update debian/rules
    - update debian/mozconfig.in

  [ Chris Coulson <email address hidden> ]
  * Add other needed files to the Gecko build system we ship in the SDK,
    based on work from the globalmenu-extension
    - update debian/create-build-system.sh
 -- Chris Coulson <email address hidden> Wed, 12 Jan 2011 11:54:53 -0600

Changed in xulrunner-2.0 (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.