NetworkManager crashed with SIGSEGV in g_closure_invoke()

Bug #737713 reported by Rachel Greenham
134
This bug affects 13 people
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Fix Released
High
Mathieu Trudel-Lapierre

Bug Description

Binary package hint: network-manager

Happened on login after most recent upgrade and reboot (for new nvidia driver)

After error occurred, still had the network manager indicator icon in my menubar; and the network connection itself (wired, eth0, dhcp). However, *sometimes* (unpredictably, inconsistently) I log in and see *two* such icons (both of which reflect changes to either one); and usually logging out and in again gets me back to one. So maybe this time I was also getting two, but one of them crashed?

ProblemType: Crash
DistroRelease: Ubuntu 11.04
Package: network-manager 0.8.4~git.20110228t143901.5cdded6-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-7.35-generic 2.6.38
Uname: Linux 2.6.38-7-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
CRDA: Error: [Errno 2] No such file or directory
Date: Fri Mar 18 17:50:34 2011
ExecutablePath: /usr/sbin/NetworkManager
Gconf:

IfupdownConfig:
 auto lo
 iface lo inet loopback
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
IpRoute:
 192.168.0.0/24 dev eth0 proto kernel scope link src 192.168.0.2 metric 1
 169.254.0.0/16 dev eth0 scope link metric 1000
 default via 192.168.0.1 dev eth0 proto static
IwConfig:
 lo no wireless extensions.

 eth0 no wireless extensions.
Keyfiles: Error: [Errno 2] No such file or directory
NetworkManager.state:
 [main]
 NetworkingEnabled=true
 WirelessEnabled=true
 WWANEnabled=true
ProcCmdline: NetworkManager
ProcEnviron: PATH=(custom, no user)
RfKill:

SegvAnalysis:
 Segfault happened at: 0x44c0ac: mov 0x68(%rax),%rax
 PC (0x0044c0ac) ok
 source "0x68(%rax)" (0x00000068) not located in a known VMA region (needed readable region)!
 destination "%rax" ok
SegvReason: reading NULL VMA
Signal: 11
SourcePackage: network-manager
StacktraceTop:
 ?? ()
 g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 ?? () from /usr/lib/libgobject-2.0.so.0
 g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
 g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
Title: NetworkManager crashed with SIGSEGV in g_closure_invoke()
UpgradeStatus: Upgraded to natty on 2011-02-26 (20 days ago)
UserGroups:

Revision history for this message
Rachel Greenham (rachel-strangenoises) wrote :
Revision history for this message
Apport retracing service (apport) wrote :

StacktraceTop:
 provider_cancel_secrets (provider=0xe2a4b0, user_data=0xe2f040) at nm-manager.c:2587
 g_closure_invoke (closure=0xe2c2e0, return_value=0x0, n_param_values=1, param_values=0xe7d7a0, invocation_hint=0x7fff19ea0570) at /build/buildd/glib2.0-2.28.3/./gobject/gclosure.c:767
 signal_emit_unlocked_R (node=<value optimized out>, detail=0, instance=0xe2a4b0, emission_return=0x0, instance_and_params=0xe7d7a0) at /build/buildd/glib2.0-2.28.3/./gobject/gsignal.c:3252
 g_signal_emit_valist (instance=<value optimized out>, signal_id=<value optimized out>, detail=<value optimized out>, var_args=<value optimized out>) at /build/buildd/glib2.0-2.28.3/./gobject/gsignal.c:2983
 g_signal_emit_by_name (instance=0xe2a4b0, detailed_signal=0x48e7ec "manager-cancel-secrets") at /build/buildd/glib2.0-2.28.3/./gobject/gsignal.c:3077

Revision history for this message
Apport retracing service (apport) wrote : Stacktrace.txt
Revision history for this message
Apport retracing service (apport) wrote : ThreadStacktrace.txt
Changed in network-manager (Ubuntu):
importance: Undecided → Medium
tags: removed: need-amd64-retrace
visibility: private → public
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks like at the point when NetworkManager closes, it cleans up the NMManager object before secrets requests have the time to be cleared up for VPNs. This shouldn't affect users overly after release (since it only really crashes when NM gets stopped, and we won't run apport automatically), but it still deserves to be fixed, just need to clarify *how* to do this with dcbw.

Changed in network-manager (Ubuntu):
status: New → Confirmed
importance: Medium → High
Changed in network-manager (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Got a patch done; since it's not an issue that will gravely affect the release I think it can wait until checked out properly by dcbw first, before upload.

Essentially, clean up the VPN connections and disconnect signals from the activation requests before unref'ing vpn_manager; otherwise the signals get received and the callback for them tries to ask the NMManager object for stuff, but the object has already been cleared.

Why I'm saying this won't gravely affect the release is because it's a crash that happens when NM is stopped (which means it ends up stopped, ie not running anymore, anyway), it still starts up fine after, and we won't be showing apport dialogs past FinalFreeze. Regardless, we'll still be fixing this.

tags: added: patch-forwarded-upstream
Changed in network-manager (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Reworked patch after review.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 0.8.4~git.20110319t175609.d14809b-0ubuntu3

---------------
network-manager (0.8.4~git.20110319t175609.d14809b-0ubuntu3) natty; urgency=low

  * debian/patches/git_disconn_secrets_reqs_b613a17.patch: fix cleaning up
    NMVPNManager objects when stopping the deamon. (LP: #737713)
  * debian/patches/git_wwan_state_detection_d0a1b23.patch: fix enabled state
    detection. (LP: #756553)
  * debian/patches/git_wired_ap_scan_value_a262dc4.patch: wired 802.1x
    connections need to set ap_scan=0 for the supplicant, which apparently had
    been dropped at some point.
 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 14 Apr 2011 17:24:02 -0400

Changed in network-manager (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.