Add touch gesture events

Bug #742582 reported by Duncan McGreggor
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Grail
Fix Released
Critical
Henrik Rydberg
utouch-grail (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

Feature Freeze Exception:

The current uTouch stack does not have any gesture events that fire when touches begin. Touches must move to cross a threshold before emitting any events. However, gestures on touch begin is a necessary functionality for Natty Unity work. The related branches include the addition of a new "touch" gesture type.

This new code is in ppa:utouch-team/unstable and is being actively used and developed against by the Unity team. This feature is necessary to meet all the Natty development goals.

Due to the manner in which touch gestures are implemented, the regression risk posed is moderate. However, the changes made have been viewed by the team as bringing the code more in line with the ideal logic for gesture handling. This has led to some simplification of the code and fixing of other unseen bugs. As such, though the regression risk is not trivial, we believe it is reasonable to propose inclusion of the changes into Natty at this stage.

Just as a note, this inctroduces an ABI addition (no API changes, and no ABI breakages).

Related branches

Changed in utouch-grail (Ubuntu):
assignee: nobody → Henrik Rydberg (rydberg)
Changed in utouch-grail:
importance: Undecided → Critical
status: New → In Progress
assignee: nobody → Henrik Rydberg (rydberg)
summary: - GEIS doesn't get touch the touch initialization signals from grail
+ Add touch gesture events
Changed in utouch-grail (Ubuntu):
status: New → In Progress
Changed in utouch-grail:
status: In Progress → Fix Committed
description: updated
Changed in utouch-grail (Ubuntu):
status: In Progress → New
milestone: none → ubuntu-11.04-beta-2
importance: Undecided → Critical
Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 742582] [NEW] Add touch gesture events

Seems like rather late in the cycle for this. When will the FFe's for touch
be done?

Revision history for this message
Chase Douglas (chasedouglas) wrote :
Revision history for this message
Chase Douglas (chasedouglas) wrote :
Revision history for this message
Chase Douglas (chasedouglas) wrote :

This was not a planned feature, so we didn't have any foresight on developing it before feature freeze.

Revision history for this message
Martin Pitt (pitti) wrote :

The description sounds very similar to bug 742555, so TBH I'm not quite sure why there's two FFEs for this.

https://code.launchpad.net/~utouch-packaging/utouch-grail/packaging.touch-gestures/+merge/55235 looks weird to me: why do we have so many patches in the package? Aren't we upstream for this stuff anyway, i. e. can't this just become a new upstream release?

Please note that usually FFEs should be requested _before_ adding dependencies to the new thing (which basically turns this into a done deal with not much choice left). IMHO It is way too late to introduce stuff like this, which is not just a matter of a bit of new code, but also design/behaviour changes and new testing requirements.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I'll just address the patches issue. We have already started work on features beyond the scope of natty. These changes have already been pushed to trunk for utouch-grail. Any future releases of utouch-grail would either have the new features too, or we would have to revert commits. It makes the most sense instead to leave utouch-grail at version 1.0.20 for natty and add patches for any additional bug fixes and/or features as necessary.

Revision history for this message
Henrik Rydberg (rydberg) wrote :

Regarding the timing of these changes, I believe we are all aware they are late indeed. The reason we still propose them is probably also clear to everyone.

Regarding the nature of the changes, the impact on existing setups is much smaller than what it may seem like. It is not exactly zero, but it is close to it. The new behavior is only seen if switched on explicitly, as done by necessity in unity trunk.

Regarding the number of patches, three of the four patches are pure bugfixes, as can be seen in the LP references in the change log.

Henrik Rydberg (rydberg)
Changed in utouch-grail (Ubuntu):
assignee: Henrik Rydberg (rydberg) → nobody
Revision history for this message
Martin Pitt (pitti) wrote :

Related to bug 742555, so formally approving as well.

Changed in utouch-grail (Ubuntu):
status: New → Confirmed
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

I would like to make this very clear to everyone (not addressing the bug fix patches, just the addition of touch gestures):
 * the change is a result of a missed bit of functionality that was buried in the design document
 * Henrik has addressed the nature of the impact on other components here, which is minimal
 * no one noticed the requirement until Jason attempted to get immediate touch feedback when implementing MT in Unity
 * Unity requires this
 * if anyone has any problems with this change, they need to take it up with Mark Shuttleworth

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 742582] Re: Add touch gesture events

On Friday, April 01, 2011 08:56:01 AM you wrote:
> if anyone has any problems with this change, they need to take it up with
> Mark Shuttleworth

Sorry. That doesn't play. Only the sabdfl gets to be sabdfl. I don't have an
opinion on the patch itself, but this is completely inappropriate and
disrespectful of the release team and the role it plays in Ubuntu.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package utouch-grail - 1.0.20-0ubuntu3

---------------
utouch-grail (1.0.20-0ubuntu3) natty; urgency=low

  * Prevent rotation gestures on semi-mt trackpads (LP: #724979)
  * Add touch gestures (LP: #742582)
  * Ensure all started gestures end (LP: #744391)
 -- Chase Douglas <email address hidden> Fri, 01 Apr 2011 09:04:23 -0400

Changed in utouch-grail (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

On 04/01/2011 07:18 AM, Scott Kitterman wrote:
> On Friday, April 01, 2011 08:56:01 AM you wrote:
>> if anyone has any problems with this change, they need to take it up with
>> Mark Shuttleworth
>
> Sorry. That doesn't play. Only the sabdfl gets to be sabdfl. I don't have an
> opinion on the patch itself, but this is completely inappropriate and
> disrespectful of the release team and the role it plays in Ubuntu.

Then you have misunderstood my intent: there are layers of dependencies
here (code, designs, features -- ultimately directed by and signed off
by Mark). We are simply doing our jobs to make sure they are fulfilled.
He wants this stuff in there, and if you guys don't approve, for
whatever reason (yes, I know it's been approved now), then that's who
you need to take it up with.

I'm wasn't being disrespectful, only letting you know that we had
reached the end of the line: we had given you all the info, explained
the reasons for everything, and are simply not in a position to address
anything beyond that.

Hope that clarifies that bullet point.

Revision history for this message
Scott Kitterman (kitterman) wrote :

I've contemplated your response and didn't come up with something that's
consistent with the CoC, so I'll stop here.

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Scott,

I owe you an apology.

After chatting with those in the know, I see now that I basically walked all over the release team's governance charter. I extend my deepest apologies for this.

As I now understand things, it is you all in the Release Team who provide the ultimate guidance on the release of Ubuntu, and that whether or not my comments were intended as disrespectful or insulting, they were, in fact, just that.

On a side note, in the face of this, you exhibited amazing restraint and provided the space necessary for me to confer with my peers, get educated, and reflect on the proper context here.

Thanks!

And what's more, thanks for all of your efforts and work in helping Ubuntu get released each cycle :-)

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

I just caught up with the thread in this bug.

Scott, you're right, Duncan was out of line to phrase the request the
way he did. I had reminded the touch and Unity teams the set of gestures
they were supposed to support and deliver, and that required the API /
ABI change. The only consumer of those API's is Unity, and the gestures
are essential for the usability of the interface with multi-touch pads.
So, since the regression risk was tightly contained, it seemed a
reasonable ask.

Mark

Revision history for this message
Scott Kitterman (kitterman) wrote :

Duncan has apologized and we've had some additional communication outside the
bug. To close the loop here, I think the social issue here is resolved (as
well as the technical one) and we can move on.

Stephen M. Webb (bregma)
Changed in utouch-grail:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.