yuixhr integration tests require unnecessary boilerplate and unnecessary server restarts
Bug #872089 reported by
Gary Poster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Gary Poster | ||
Bug Description
[This is mostly a bug to which I can link a branch for QA annotations. I'm making this change, and a few others, in preparation for landing a fix for bug 724609.]
yuixhr integration tests can provide a one-line helper to do all of the JS boilerplate found at the end of the standard template. We should do this.
Related branches
lp:~gary/launchpad/bug872089
- Graham Binns (community): Approve (code)
-
Diff: 702 lines (+385/-97)8 files modifiedlib/canonical/launchpad/scripts/runlaunchpad.py (+21/-7)
lib/lp/app/javascript/server_fixture.js (+23/-1)
lib/lp/testing/tests/test_standard_yuixhr_test_template.js (+3/-15)
lib/lp/testing/tests/test_yuixhr.py (+105/-1)
lib/lp/testing/tests/test_yuixhr_fixture.js (+6/-13)
lib/lp/testing/tests/test_yuixhr_fixture_facet.js (+27/-0)
lib/lp/testing/tests/test_yuixhr_fixture_facet.py (+17/-0)
lib/lp/testing/yuixhr.py (+183/-60)
Revision history for this message
| William Grant (wgrant) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| Changed in launchpad: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
buildbot says:
Failure in test lp/testing/
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
File "/srv/buildbot/
self.fail("js timed out.")
AssertionError: js timed out.
So I've reverted it in r14150.