Code review comment for lp:~a.skwar/mylvmbackup/zfs
Revision history for this message
| Alexander Skwar (a.skwar) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Reg. your 2nd paragraph:
You're right. Being able to specify the size of the snap lv as a fixed size might be useful.
I'll change the code so, that it uses the % calculation only if the last char of "lvsize" is a "%". Otherwise, if it is a number (0-9), then it'll use that as a value for meaning "number of logical extents" and if it matches [kKmMgGtTpPeE], then it'll be used to mean that size in [kKmMgGtTpPeE] (IOE: if it matches [kKmMgGtTpPeE], then --size will be used).