Code review comment for lp:~a.skwar/mylvmbackup/zfs

Hi,

> Where are you backing up InnoDB data? You keep referring to DataDir but that
> is only for MyISAM.

Not necessarily - in a default configuration, InnoDB stores its table spaces inside of
the datadir as well.

> Here is how we layout our customers:
>
> basedir = /usr
> socket = /var/lib/mysql/mysql.sock
> tmpdir = /var/lib/mysql/tmp
> datadir = /var/lib/mysql/data
> log-error = /var/lib/mysql/log/error.log
> log-bin = /var/lib/mysql/binlog/binlog
> relay-log = /var/lib/mysql/relaylog/relaylog
> innodb-data-home-dir = /var/lib/mysql/innodb
> innodb-log-group-home-dir = /var/lib/mysql/innodb
>
> If we only back'd up the datadir, we'd be missing out on tons of data
> necessary to completely rebuild a customer's database from the ground up.

That's true. I guess the documentation should elaborate on that. For Linux LVM,
you need to make sure that all data is located on the same file system in order to
achieve a consistent snapshot. If your InnoDB table spaces are located outside the
default data directory, you would have to modify mylvmbackup to take this into
account.