Code review comment for lp:~abentley/launchpad/bmp-inline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 reviewer rockstar ui
 reviewer launchpad-reviewers code

= Summary =
This branch provides bug-like inline commenting for merge proposals.

== Proposed fix ==
Implement a CodeReviewComment widget that extends Comment, use it in the
page. Only show it if YUI is enabled.

Replies are not yet supported as an inline operation.

== Pre-implementation notes ==
Preimplementation was with thumper. Further discussion was with rockstar

== Implementation details ==
To ensure consistent rendering, a new url, "+fragment" is provided, so
that the HTML fragment for a particular CodeReviewComment can be retrieved.

A new canonical_url function is provided for retrieving test URLs. (The
normal urls require an SSL certificate to be accepted.)

The conversation now has a top-level div with id "conversation" to make
it easier to append to the conversation.

== Tests ==
bin/test -v --layer=CodeWindmillLayer test_merge_proposal_commenting

== Demo and Q/A ==
Create a merge proposal and go to its page. The comment form will
appear at the bottom. Make a comment or vote.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/browser/configure.zcml
  lib/lp/code/templates/branchmergeproposal-index.pt
  lib/lp/code/windmill/tests/test_merge_proposal_commenting.py
  lib/lp/code/windmill/testing.py
  lib/lp/code/templates/codereviewcomment-fragment.pt
  lib/canonical/launchpad/javascript/lp/comment.js

== JSLint notices ==
jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/lp/comment.js'.

jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/lp/errors.js'.

jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/bugs/bugtask-index.js'.

jslint: 3 files to lint.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrUt+AACgkQ0F+nu1YWqI2gEgCcDExr+O2PM2T4hjymyJAjNlXx
R38AnjWMDltSr/2fFYU5ieWX9tJgqMfT
=HhFi
-----END PGP SIGNATURE-----