Code review comment for lp:~abentley/launchpad/daily-build-freshness

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/28/2010 09:37 AM, Björn Tillenius wrote:
> Review: Needs Information db
> In general, the patch looks fine, but could you please expand on how the attributes will be set and used?

SourcePackageRecipe.is_stale
============================

When the Branch scanner sees a that the branch tip has changed for a
given branch, it will find all recipes which involve that branch, and
set is_stale to True for all of them.

When the daily builds script runs, it will look for recipes with
is_stale True and build_daily True. It will request builds for them.
Then it will set is_stale False for them.

SourcePackageRecipeBuild.manifest
=================================
When RecipeBuildBehaviour dispatches a build to a slave, it will look
for the last successful build of that type (same recipe and
distroseries) and include that build's manifest with its extra build
args. (Manifests are a form of recipe, so converting a manifest to text
is something we already do.)

The recipe building code in our buildd will be modified to use the
manifest if supplied.

When the build completes, the output manifest is (already) supplied to
RecipeBuildBehaviour. We will modify RecipeBuildBehaviour to set
SourcePackageRecipeBuild.manifest.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkv/07wACgkQ0F+nu1YWqI2LlgCdER2ysBDstTHQ0ZxJUV9HLg0n
jeoAn0YCgJQUUM8qdL1LlosSHimgDyaW
=5NhT
-----END PGP SIGNATURE-----