Code review comment for lp:~abentley/launchpad/fix-rewrite

Revision history for this message
Aaron Bentley (abentley) wrote :

= Summary =
Fix the branch-rewrite script's cache.

== Proposed fix ==
This patch fixes the "trailing path" portion of
_getBranchIdAndTrailingPath so that it has a leading slash, whether it
comes from cached data or not.

== Pre-implementation notes ==
Patch was discussed by flacoste and mwhudson, and has been cowboyed into
production, where it solved the problem.

== Implementation details ==
None

== Tests ==

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/codehosting/tests/test_rewrite.py
  lib/lp/codehosting/rewrite.py

== Pylint notices ==

lib/lp/codehosting/tests/test_rewrite.py
    129: [C0301] Line too long (81/78)
    146: [C0301] Line too long (81/78)

********** *END ENCRYPTED or SIGNED PART* **********

# Bazaar merge directive format 2 (Bazaar 0.90)

« Back to merge proposal