Code review comment for lp:~abentley/launchpad/mp-tweakage

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 reviewer beuno ui

= Summary =
Tweaks to merge proposal main page

== Proposed fix ==
linked bugs and blueprints are pulled above the comments, so they are
easy to see.

"add comment or review" is pulled into the vote table, so it is easy to
use, and to strengthen the association with the requested reviews.

'resubmit' is provided as a direct link, and placed with the information
about whether this branch supersedes another branch.

== Pre-implementation notes ==
None

== Implementation details ==
I haven't removed the "resubmit" merge proposal status yet, but
providing resubmit as a link obsoletes it.

== Tests ==
None. I want to get the UI approved before I polish.

== Demo and Q/A ==
Create a merge proposal, and link a bug to the source branch. Go to the
main merge proposal page. See "Proposed fix" for what the page should
look like.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/templates/branchmergeproposal-index.pt
  lib/lp/code/browser/branchmergeproposal.py
  lib/lp/code/templates/branchmergeproposal-votes.pt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpx7rcACgkQ0F+nu1YWqI3oJACePEgSs4FW87Kz16Sp1qZGFUXg
QMIAnR7FJdhZV+rjzcSjVzKMEPNxjWJN
=FyY9
-----END PGP SIGNATURE-----

« Back to merge proposal