Code review comment for lp:~abentley/launchpad/mp-tweakage

Hi Aaron,

It's nice to see work on merge proposals.

I feel that going down the path of "Add a review or comment" has not been good. Reviewing and commenting are very different things, and mixing them just creates confusion.
I think we should clearly separate them into different links, and just distinguish the page it goes to by having the review section collapsed or expanded by default. That way we still allow people to do both, but lead them down two different paths.

I also think the way that the links are piled up make it hard to find them. When I have been requested to review, I have a [Review] link, and a "Add a review or comment" very close to it. Makes me think that, leaving aside the issue mentioned before, that link should at a very minimum be outside the table.

As for the link to resubmit the proposal, I feel that clicking a link to then click a button is not the best experience. Can't we just have the button (as a link!) on the page?
In the 3.0 spirit, this seems like something that would go on the global actions portlets we will have on the top-right. Since that template is not yet available, I think we should fix it's current placement, which feels slapped on randomly. I wonder if the right place is where we display commits? That area can be pushed down quite a bit, so I don't know.

In general, I think this branch doesn't improve the user experience, but the spirit and direction is good, so with some work it will be great.