Code review comment for lp:~abentley/launchpad/mp-tweakage

Revision history for this message
Robert Collins (lifeless) wrote :

On Thu, 2009-07-30 at 22:46 +0000, Martin Albisetti wrote:
>
> I feel that going down the path of "Add a review or comment" has not
> been good. Reviewing and commenting are very different things, and
> mixing them just creates confusion.
> I think we should clearly separate them into different links, and just
> distinguish the page it goes to by having the review section collapsed
> or expanded by default. That way we still allow people to do both, but
> lead them down two different paths.

Huh? I review by email, and I think that commenting and reviewing are
nearly identical. The only difference (to me) is that sometimes I don't
feel my opinion fits the launchpad set of values strongly or clearly
enough to express, and in those cases I don't give lp a specific
command.

-Rob

(Commenting, in this case :P)

« Back to merge proposal