Code review comment for lp:~abentley/launchpad/mp-tweakage

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Thu, Jul 30, 2009 at 11:05:17PM -0000, Martin Albisetti wrote:
> > Huh? I review by email, and I think that commenting and reviewing are
> > nearly identical. The only difference (to me) is that sometimes I don't
> > feel my opinion fits the launchpad set of values strongly or clearly
> > enough to express, and in those cases I don't give lp a specific
> > command.
>
> That's because you're a reviewer. As a reviewer, the line is
> blurry-er. As someone who just has an opinion, it's not.

If we do go down the path of separating commenting and reviewing, please
add a way of subscribing to the merge proposal if you comment on it
only. At the moment you have to add yourself as a reviewer, meaning that
even this comment is a kind of review.

    vote abstain

review: Abstain

« Back to merge proposal