Code review comment for lp:~abentley/launchpad/parse-binary

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
Fix bugs 436325 and 436794 by updating bzr and diffstat generation

== Proposed fix ==
Skip binary files when generating diffstats

== Pre-implementation notes ==
No pre-implementation was done, but the bzr changes were approved by vila.

== Implementation details ==
bzr was updated to 2.0-lp-2, which correctly parses binary sections, and
 permits unicode filenames.

The diffstat generation was updated to skip binary patch sections.

== Tests ==
bin/test -v test_fromFileAcceptsBinary

== Demo and Q/A ==
Create a branch containing a binary file with a unicode filename.
Branch it, and modify the file.
Propose the second branch for merging into the first.
A diff should be generated, with no OOPs.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  versions.cfg
  lib/lp/code/model/diff.py
  lib/lp/code/model/tests/test_diff.py

== Pylint notices ==

lib/lp/code/model/diff.py
    17: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)
    166: [W0703, Diff.fromFile] Catch "Exception"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAkrc3IkACgkQ0F+nu1YWqI2O4QCfW8sxKPICQKsX64QwD/Z47KPk
zbAAljW1R0JwgNqz/qEj5hou0DXo7g4=
=5cev
-----END PGP SIGNATURE-----