Code review comment for lp:~abentley/launchpad/reassign

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 reviewer beuno ui

= Summary =
Allow review requests to be claimed, which can avoid two people working
on a review in parallel. Allow reviews to be reassigned, in case the
claimant changes their mind.

== Proposed fix ==
When a review is assigned to a team, any member of the team can hit the
"claim review" button to claim it.

The person assigned to perform a review can reassign it, and the person
who requested the review can also reassign it.

== Pre-implementation notes ==
Pre- and mid-implementation discussion was with thumper and rockstar

== Implementation details ==
The ability to change a reviewer is now granted by launchpad.Edit on
CodeReviewVoteReference

== Tests ==

== Demo and Q/A ==
Log in as no privilages person. Create a merge proposal and request
Mark Shuttleworth to review it. Reassign it to hwdb-team.

Log in as Foo Bar. Go to the merge proposal page. Claim the review.
Reassign it to Mark Shuttleworth. Note that you can no longer reassign
it, because you are not the requested reviewer.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/browser/configure.zcml
  lib/lp/code/configure.zcml
  lib/canonical/launchpad/security.py
  lib/canonical/launchpad/pagetitles.py
  lib/lp/code/browser/tests/test_branchmergeproposal.py
  lib/lp/code/browser/branchmergeproposal.py
  lib/lp/code/templates/branchmergeproposal-votes.pt
  lib/lp/code/templates/reviewrequest-reassign.pt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpxrD0ACgkQ0F+nu1YWqI3BXwCeM0cbcTuN51JG/aVFNCtm5t6W
KksAniigxjSXdkZ4KKqQ4fUbR+HvNJXC
=FmfX
-----END PGP SIGNATURE-----