= Summary =
Support inline replies for code review
== Proposed fix ==
When a user clicks on a reply link, the review/comment box is populated
with the comment as an email-style reply and the browser is scrolled
down to the widget.
== Pre-implementation notes ==
Preimplementation was with thumper
== Implementation details ==
I had to drag the email-style-reply code into the model because I wanted
to expose it for the API.
== Tests ==
None
== Demo and Q/A ==
Create a code review comment. Reply to it. In your mail client,
observe that threading is preserved correctly.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
== JSLint notices ==
No handlers could be found for logger "bzr"
jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/lp/comment.js'.
jslint: 1 file to lint.
== Pylint notices ==
lib/lp/code/interfaces/codereviewcomment.py
22: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)
23: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)
lib/lp/code/browser/codereviewcomment.py
20: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)
21: [F0401] Unable to import 'lazr.restful.interface' (No module
named restful)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
= Summary =
Support inline replies for code review
== Proposed fix ==
When a user clicks on a reply link, the review/comment box is populated
with the comment as an email-style reply and the browser is scrolled
down to the widget.
== Pre-implementation notes ==
Preimplementation was with thumper
== Implementation details ==
I had to drag the email-style-reply code into the model because I wanted
to expose it for the API.
== Tests ==
None
== Demo and Q/A ==
Create a code review comment. Reply to it. In your mail client,
observe that threading is preserved correctly.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: code/interfaces /codereviewcomm ent.py code/browser/ codereviewcomme nt.py code/model/ codereviewcomme nt.py /launchpad/ javascript/ lp/comment. js
lib/lp/
lib/lp/
lib/lp/
lib/canonical
== JSLint notices == abentley/ launchpad/ inline- comment/ lib/canonical/ launchpad/ javascript/ lp/comment. js'.
No handlers could be found for logger "bzr"
jslint: No problem found in
'/home/
jslint: 1 file to lint.
== Pylint notices ==
lib/lp/ code/interfaces /codereviewcomm ent.py fields' (No module named declarations' (No module
22: [F0401] Unable to import 'lazr.restful.
restful)
23: [F0401] Unable to import 'lazr.restful.
named restful)
lib/lp/ code/browser/ codereviewcomme nt.py interface' (No module enigmail. mozdev. org
20: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)
21: [F0401] Unable to import 'lazr.restful.
named restful)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkr ffF0ACgkQ0F+ nu1YWqI19OgCeOh DWoVdqbv4cEMwfC gZqMF4E F10hrUAc7S9dTWM Lk0qk64E
PEYAnReM+
=7YkU
-----END PGP SIGNATURE-----