-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
= Summary = Style branch merge proposal subscriptions to match branch subscriptions
== Proposed fix == Stop using <dl? and <dt>, start using <ul> and <li> to fix the font weight
Stop using <img src="/@@/yes" /> to remove the checkmark
== Pre-implementation notes == Pre-implementation was with Tim
== Implementation details == Removed unreachable code for saying that no one was subscribed. Code was essentially:
<div tal:condition="view/full_subscribers"> <div tal:condition="not view/full_subscribers"> No one </div> </div>
== Tests == None
== Demo and Q/A == Go to a branch merge proposal page. Make sure the subscriber list looks like a branch subscriber list.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates. Running jslint, xmllint, pyflakes, and pylint. Using normal rules.
Linting changed files: lib/lp/code/templates/branchmergeproposal-pagelet-subscribers.pt -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkqylZEACgkQ0F+nu1YWqI3JyQCfaTQ1bULcjV6u565vjMTnbGYv lbEAn1VNg+asVTp9BM8yAGrhpaRAqof+ =RvZM -----END PGP SIGNATURE-----
« Back to merge proposal
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
= Summary =
Style branch merge proposal subscriptions to match branch subscriptions
== Proposed fix ==
Stop using <dl? and <dt>, start using <ul> and <li> to fix the font weight
Stop using <img src="/@@/yes" /> to remove the checkmark
== Pre-implementation notes ==
Pre-implementation was with Tim
== Implementation details ==
Removed unreachable code for saying that no one was subscribed. Code
was essentially:
<div tal:condition= "view/full_ subscribers" > subscribers" > No one </div>
<div tal:condition="not view/full_
</div>
== Tests ==
None
== Demo and Q/A ==
Go to a branch merge proposal page. Make sure the subscriber list looks
like a branch subscriber list.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: code/templates/ branchmergeprop osal-pagelet- subscribers. pt enigmail. mozdev. org
lib/lp/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkq ylZEACgkQ0F+ nu1YWqI3JyQCfaT Q1bULcjV6u565vj MTnbGYv asVTp9BM8yAGrhp aRAqof+
lbEAn1VNg+
=RvZM
-----END PGP SIGNATURE-----