Code review comment for lp:~abentley/launchpad/use-existing

Revision history for this message
Māris Fogels (mars) wrote :

Hi Aaron,

This changes looks good. Nice tests. r=mars

The only recommendation I have is somehow making it clear that setting the ControlFormat(?) counts as creating an existing .bzr directory. The command is black magic to me (perhaps it's obvious to someone who works in the Bazaar domain? Something like .add_bzr_control_directory()? :)

Maris

review: Approve

« Back to merge proposal