Merge lp:~abreu-alexandre/v8-cpp/fix-v8-build-wily into lp:v8-cpp

Proposed by Alexandre Abreu
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 29
Merged at revision: 29
Proposed branch: lp:~abreu-alexandre/v8-cpp/fix-v8-build-wily
Merge into: lp:v8-cpp
Diff against target: 31 lines (+16/-0)
2 files modified
deps/build-deps.sh (+1/-0)
deps/patches/v8/fix-signed-overflow-bignum-error.patch (+15/-0)
To merge this branch: bzr merge lp:~abreu-alexandre/v8-cpp/fix-v8-build-wily
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
Review via email: mp+270840@code.launchpad.net

Description of the change

Fix v8 build w/ gcc 5.2.1 & -Werror=strict-overflow

To post a comment you must log in.
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Awesome thanks for that!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'deps/build-deps.sh'
--- deps/build-deps.sh 2015-08-31 04:13:15 +0000
+++ deps/build-deps.sh 2015-09-11 15:18:15 +0000
@@ -19,4 +19,5 @@
19gclient sync19gclient sync
2020
21cd v821cd v8
22git apply $DIR/patches/v8/*.patch
22make -j3 native i18nsupport=off23make -j3 native i18nsupport=off
2324
=== added directory 'deps/patches'
=== added directory 'deps/patches/v8'
=== added file 'deps/patches/v8/fix-signed-overflow-bignum-error.patch'
--- deps/patches/v8/fix-signed-overflow-bignum-error.patch 1970-01-01 00:00:00 +0000
+++ deps/patches/v8/fix-signed-overflow-bignum-error.patch 2015-09-11 15:18:15 +0000
@@ -0,0 +1,15 @@
1diff --git a/src/bignum.cc b/src/bignum.cc
2index 254cb01..767192b 100644
3--- a/src/bignum.cc
4+++ b/src/bignum.cc
5@@ -83,8 +83,8 @@ void Bignum::AssignDecimalString(Vector<const char> value) {
6 // 2^64 = 18446744073709551616 > 10^19
7 const int kMaxUint64DecimalDigits = 19;
8 Zero();
9- int length = value.length();
10- int pos = 0;
11+ size_t length = value.length();
12+ size_t pos = 0;
13 // Let's just say that each digit needs 4 bits.
14 while (length >= kMaxUint64DecimalDigits) {
15 uint64_t digits = ReadUInt64(value, pos, kMaxUint64DecimalDigits);

Subscribers

People subscribed via source and target branches