Code review comment for lp:~adeuring/launchpad/bug-172507

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Abel!

This is a nice touch (and it's great that you're adding the SVG too!).

I think you might have forgot to update the icon used in the comment itself?

http://people.canonical.com/~michaeln/tmp/patch-icon-eg.png

I'm assuming that that is where the differentiation will be useful?

One other thought that you can ignore - it'd be nice if when clicking on 'Add patch', the 'This attachment is a patch' check box was already selected for you. But I'm guessing it's not in the scope here ;).

review: Needs Fixing (ui)

« Back to merge proposal