Code review comment for lp:~adeuring/launchpad/bug-344054

Revision history for this message
Gavin Panella (allenap) wrote :

As discussed on IRC, the new properties are probably better off as
view properties.

  <allenap> adeuring: My gut feeling is that regular_attachments and
    patches should be view properties rather than model
    properties. Did you consider that?

  <adeuring> allenap: right, good idea. didn't think about that

  <allenap> adeuring: My feeling is that they should not be exported
    in any case. If you're a consumer of the API, I think it's better
    to get the list of all attachments and split it up from there; the
    criteria for a patch are unambiguous and easy to test. Exporting
    two (well, three) attachment fields, we also encourage people to
    make multiple API calls.

  <adeuring> allenap: yeah; I'll use browser methods

review: Needs Fixing

« Back to merge proposal