Code review comment for lp:~adeuring/launchpad/bug-344054

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Abel.

I tried your branch. This is what I saw after uploading an attachment and a patch.
    http://people.canonical.com/~curtis/patch.png

I also noted that the comment form reads
    (+) Add an attachment
But the portlets reads
    (+) Add attachment or patch

Since the add attachment link is crafted, I think we should make the actions we expected the user to perform clear. We avoid the use of articles like 'a' and 'an' in our links, I think we should fix the link at the bottom of the page:

Page:
    (+) Add attachment or patch

Bug attachment portlet:
    (+) Add attachment

Patch portlet:
    (+) Add patch

review: Needs Information (ui)

« Back to merge proposal