Code review comment for lp:~adeuring/launchpad/bug-344054

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Curtis,

changes applied.

Abel

=== modified file 'lib/lp/bugs/browser/bug.py'
--- lib/lp/bugs/browser/bug.py 2009-12-09 11:14:16 +0000
+++ lib/lp/bugs/browser/bug.py 2009-12-09 16:25:58 +0000
@@ -234,7 +234,7 @@

     def addcomment(self):
         """Return the 'Comment or attach file' Link."""
- text = 'Add an attachment'
+ text = 'Add attachment or patch'
         return Link('+addcomment', text, icon='add')

     def addbranch(self):

=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-index.txt'
--- lib/lp/bugs/stories/bugs/xx-bug-index.txt 2009-09-23 11:10:00 +0000
+++ lib/lp/bugs/stories/bugs/xx-bug-index.txt 2009-12-09 16:30:45 +0000
@@ -127,10 +127,10 @@
     >>> print user_browser.getLink('List open bugs').url
     http://launchpad.dev/ubuntu/+source/mozilla-firefox/+bugs

-There's also a link on the page that will take the user to the "Add an
-attachment" page, for use when JavaScript isn't available.
+There's also a link on the page that will take the user to the "Add
+attachment or patch" page, for use when JavaScript isn't available.

- >>> print user_browser.getLink('Add an attachment').url
+ >>> print user_browser.getLink('Add attachment or patch').url
     http://bugs.launchpad.dev/ubuntu/+source/.../+bug/1/+addcomment

=== modified file 'lib/lp/bugs/templates/bug-portlet-attachments.pt'
--- lib/lp/bugs/templates/bug-portlet-attachments.pt 2009-12-09 11:14:16 +0000
+++ lib/lp/bugs/templates/bug-portlet-attachments.pt 2009-12-09 16:24:32 +0000
@@ -22,7 +22,7 @@
     <ul>
       <li>
         <a tal:attributes="href view/current_bugtask/fmt:url/+addcomment"
- class="sprite add">Add attachment or patch</a>
+ class="sprite add">Add attachment</a>
       </li>
     </ul>
   </div>
@@ -44,7 +44,7 @@
     <ul>
       <li>
         <a tal:attributes="href view/current_bugtask/fmt:url/+addcomment"
- class="sprite add">Add attachment or patch</a>
+ class="sprite add">Add patch</a>
       </li>
     </ul>
   </div>

« Back to merge proposal