Code review comment for lp:~adeuring/launchpad/bug-438024-parse-dmi-data

Revision history for this message
Abel Deuring (adeuring) wrote :

This branch adds a method SubmissionParser._parseDmi().

The HWDB client in Karmic will no longer submit data containing HAL data; instead it will send data from udev, some DMI data and devices properties stored in sysfs files.

SubmissionParser._parseDmi() converts the text data from the <dmi> node as provided by the HWDB client into a simple dicitionary.

test:

./bin/test -t test_hwdb_submission_parser

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/scripts/hwdbsubmissions.py
  lib/canonical/launchpad/scripts/tests/test_hwdb_submission_parser.py

== Pyflakes notices ==

lib/canonical/launchpad/scripts/hwdbsubmissions.py
    22: redefinition of unused 'etree' from line 20

lib/canonical/launchpad/scripts/tests/test_hwdb_submission_parser.py
    10: redefinition of unused 'etree' from line 8

== Pylint notices ==

lib/canonical/launchpad/scripts/hwdbsubmissions.py
    20: [F0401] Unable to import 'xml.etree.cElementTree' (No module named etree)

This message is not related to my changes; it was introduced by a branch that prepares the transistion to Python 2.5.

« Back to merge proposal