Code review comment for lp:~adeuring/launchpad/bug-507642

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Went through this on IRC. Changes:

 * Don't test the entire integration chain for each affected attribute (exceeding the hard limit on snapshots, then simulating a post). Instead, test once that exceeding the hardlimit on one attribute no longer breaks things; then for each of the attributes test that snapshotting is disabled.

 * Move things out of setUp where appropriate; generate all those bug subscribers or whatever using factory.makePersonNoCommit and there's no need for database commits (after the login).

 * The test docstring was basically one huge sentence, obscuring the essentials.

 * The range(5) should be range(<current limit> + 1)

Go land that baby!

review: Approve (code)

« Back to merge proposal