Code review comment for lp:~adeuring/launchpad/bug-513382
Revision history for this message
| Abel Deuring (adeuring) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Brad,
On 23.02.2010 21:12, Brad Crittenden wrote:
> Review: Needs Information code
> I don't understand the second paragraph above where you explain why the images can't be in the sprite. Can you elaborate?
>
> If indeed the images must be discrete then the code looks fine.
The images carry unique information, the heat level: There is no other
content on the page that says "heat level 3". So, in order to adhere to
accessibility rules, we should provide an altternative text, like the
alt attribute of an <img> tag. Sprites on the other hand can be used
only for background images, as far as I understand it, and since
background images are purely "decorative", there is no way to associate
textual information with them.
Also, we want a title attribute where we show some more or less
interesting additional information, see bug 513219. IOW, a second reason
not to use a background image.
Abel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iD8DBQFLhFRCekB
KPT3EAvUBCkw0Za
=0xDU
-----END PGP SIGNATURE-----