Code review comment for lp:~adeuring/launchpad/bug-513382

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Abel,

Yep, but I'm not sure how important that is? I'll let you guys decide that. Also, regarding searching/keyboard navigation, I would recommend going with the full solution at:

http://www.webaim.org/techniques/css/invisiblecontent/

rather than my simplified example. You'll see there that they identify:

"A previous version of this article recommended using left:0px; top:-500px. While this worked by positioning the content above the top of the page, we've since discovered that if the hidden element contained a link or form element, that upon receiving keyboard focus, the browser would attempt to scroll to the element - thus scrolling the browser to the top of the page. This could result in confusion for sighted keyboard users. By positioning directly to the left, the browser will not scroll to the top of the page."

And finally, I think it's worth bringing this up at the next UI meeting to discuss (on Monday)... others might disagree with me :)

« Back to merge proposal