Code review comment for lp:~adeuring/launchpad/bug-513382

Revision history for this message
Brad Crittenden (bac) wrote :

Though I haven't commented on this review lately I've been keeping up with the discussion. Based on Abel's latest discovery that the work-around will cause the psuedo-ALT text to be included in our site-wide search results I'd argue for reverting the CSS changes and going back to the original <IMG> approach so this change can get landed. It seems we need to explore a general solution to this problem, starting with the UI call on Monday, and once that is done we can retrofit this change.

I vote 'Approve' on the original version.

Abel please save the work you've done as it will be a good starting point for the broader discussion.

review: Approve (code)

« Back to merge proposal