Code review comment for lp:~adeuring/launchpad/bug-513382

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> Michael, or you ok to review the end-result of the UI -- i.e. that the images
> look right on the site -- and defer implementation details to code review and
> a UI call discussion?

Yep, the UI looks great (as it did at the start :) ), and needs to land!

I *do* think you should check with Curtis, as it seems that we already have a standard way to do this (with the discussed pros/cons already evaluated), and it's pretty much what Abel has implemented with r10375 (it only needs to be updated to use the span.invisible that's already there for this exact reason). But again, that's up to you guys.

review: Approve (ui)

« Back to merge proposal