Code review comment for lp:~adeuring/launchpad/bug-528569-api-bug-search-for-linked-branches
Revision history for this message
| Abel Deuring (adeuring) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Gavin,
thanks for the review!
On 10.03.2010 18:21, Gavin Panella wrote:
> Review: Approve code
> Having to use the long name from the enum when passing this parameter is
> truly awful, but I don't think that's your problem right now. Looks good.
Right, the parameter values do not look very pretty. The problem is that
they were intended to become labels for radio buttons in the web ui, and
in this context they are more reasonable. I must admit that I never
liked the concept to use the title of enum items in calls of the
webservice API...