Launchpad itself

Code review comment for lp:~adeuring/launchpad/hwdb-build-udev-device-list-2

  1. hwdb-build-udev-device-list-2
  2. Merge into devel
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks fine. I appreciate the courage it takes to defy review limits for the cleanup.

We discussed a few superficialities on IRC. I'll trust your judgment on which tests should test the hal devices and which should test all devices. Beyond that, it looks solid to me.

review: Approve

« Back to merge proposal