Code review comment for lp:~adeuring/launchpad/hwdb-refactor-haldevice-3

Revision history for this message
Barry Warsaw (barry) wrote :

<barry> adeuring: when you raise NotImplementedError in your properties, you
        don't need to instantiate them if they have no arguments. Python will
        DTRT for you here, and it's also somewhat more efficient [11:27]

with that fix, r=me

review: Approve

« Back to merge proposal