Code review comment for lp:~adeuring/launchpad/security-guarded-test-object-factory-1

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for doing this. We discussed this over IRL chat and came up with many little improvements: chiefly renaming _LaunchpadObjectFactory to BareLaunchpadObjectFactory, moving some code out of a nested function, fixing some corner cases, and adding a test for the proxy-checking function since it turned out to be a lot less trivial than originally thought.

This is often the case when engineers say a change will be trivial.

Jeroen

review: Approve (code)

« Back to merge proposal