Launchpad itself

Code review comment for lp:~adiroiban/launchpad/bug-135008

  1. bug-135008
  2. Merge into devel
Revision history for this message
Aaron Bentley (abentley) wrote :

search_lang should not be part of the ILanguageSet interface, because ILanguageSet is meant to be the interface of a model object. I recommend adding an ISearchLanguage interface in lib/lp/translations/browser/language.py instead. This will remove the need for LanguageSetView.field_names.

review: Needs Resubmitting (code)

« Back to merge proposal