Code review comment for lp:~adiroiban/launchpad/bug-340664
Revision history for this message
| Adi Roiban (adiroiban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
= Bug 340664 =
As discussed during Translations 3.0 UI sprint, we've decided to add administration page listing all templates for a single series. This would be mostly used by maintainers, and initially should have following columns:
* template
* length (number of messages)
* languages (that have at least some translations)
* last update
* editing button
Showing priority might not be a bad idea either.
== Proposed fix ==
Add priority, length and languages to the +templates pages.
== Pre-implementation notes ==
Last update and editing buttons were added in previous branches.
I talked with Danilo and he said the screenshots are OK and this is the intended way for fixing the bug.
== Implementation details ==
distroseries-
Since both product and distribution series are using the same template for displaying templates list, I have create a base class for those views.
object-template.pt logic was moved from the template to the view and the new template should be easier to read.
== Tests ==
lp-test -t series-templates
== Demo and Q/A ==
Log in as admin and go to a product +templates page
https:/
The table should look like in this screenshot:
http://
Log in as admin and go to a distribution +templates page
The table should look like in this screenshot:
http://
When logged in as a normal user you should not see the edit, upload and admin links.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/