Code review comment for lp:~adiroiban/launchpad/bug-340664
Revision history for this message
| Adi Roiban (adiroiban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Curtis and thanks for taking the time to do this review.
I agree that the forms next url is buggy. I think it is best to open a new bug report as this diff could become to big. If you consider this is issues is valid for a new bug,I can take care of reporting and solving that bug.
I agree that it is best to use the URL formatter, rather than constructing the URL in the template.
I think we can rename „Settings” to „Edit”.
Should we keep the javascript that hides the icons and only shows them on mouseover?